Issue 21959003: Expose JSON parser through V8 API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21959003: Expose JSON parser through V8 API (Closed)

Created:
7 years, 4 months ago by jochen (gone - plz use gerrit)

Modified:
7 years, 4 months ago

Reviewers:
Sven Panne, Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Expose JSON parser through V8 API BUG=v8:2821 TEST=cctest/test-api/JSONParse R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16048

Patch Set 1 #

Total comments: 1

Created: 7 years, 4 months ago

	Unified diffs	Side-by-side diffs	Stats (+50 lines, -0 lines)
M	include/v8.h	View	1 chunk	+16 lines, -0 lines	0 comments
M	src/api.cc	View	2 chunks	+24 lines, -0 lines	1 comment
M	test/cctest/test-api.cc	View	1 chunk	+10 lines, -0 lines	0 comments

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

Hey, what do you guys think? Is this a reasonable API change?

7 years, 4 months ago (2013-08-05 08:28:38 UTC) #2

Yang

LGTM with a suggestion. https://codereview.chromium.org/21959003/diff/1/src/api.cc File src/api.cc (right): https://codereview.chromium.org/21959003/diff/1/src/api.cc#newcode2619 src/api.cc:2619: Utils::OpenHandle(*json_string)->TryFlattenGetString()); I would prefer FlattenGetString ...

7 years, 4 months ago (2013-08-05 10:52:34 UTC) #3

jochen (gone - plz use gerrit)

7 years, 4 months ago (2013-08-05 11:14:53 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r16048 (presubmit successful).

Expand Messages | Collapse Messages