tools/dm_flags.py - Issue 2195893002: Always return ImageShader, even from SkShader::MakeBitmapShader

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dm_flags.py

Issue 2195893002: Always return ImageShader, even from SkShader::MakeBitmapShader (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: update serialize-8888 ignore list: skbug.com/5595 Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/dm_flags.py

diff --git a/tools/dm_flags.py b/tools/dm_flags.py

index 2ee9358fe5406c12df86fe0410e8652ec56d02a3..fd3b2b791a53c60600ba266fe8e1c52952de8c02 100755

--- a/tools/dm_flags.py

+++ b/tools/dm_flags.py

@@ -208,6 +208,10 @@ def get_args(bot):

'filterbitmap_image_mandrill_64',

'shadows',

'simpleaaclip_aaclip'])

+ # skia:5595

+ bad_serialize_gms.extend(['composeshader_bitmap',

+ 'scaled_tilemodes_npot',

+ 'scaled_tilemodes'])

for test in bad_serialize_gms:

blacklist.extend(['serialize-8888', 'gm', '_', test])

« src/image/SkImageShader.h ('K') | « tests/ShaderTest.cpp ('k') | no next file » | no next file with comments »