src/crankshaft/ia32/lithium-codegen-ia32.cc - Issue 2195863002: [turbofan] Stub for typeof operator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/crankshaft/ia32/lithium-codegen-ia32.cc

Issue 2195863002: [turbofan] Stub for typeof operator. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix review comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/crankshaft/ia32/lithium-codegen-ia32.cc

diff --git a/src/crankshaft/ia32/lithium-codegen-ia32.cc b/src/crankshaft/ia32/lithium-codegen-ia32.cc

index b6f9811a1410a88f0e56606f351d450f501e8560..36f9e3e7bb243b204ed7f70d6fe12f82ebc0580c 100644

--- a/src/crankshaft/ia32/lithium-codegen-ia32.cc

+++ b/src/crankshaft/ia32/lithium-codegen-ia32.cc

@@ -4946,8 +4946,8 @@ void LCodeGen::DoTypeof(LTypeof* instr) {

__ mov(eax, Immediate(isolate()->factory()->number_string()));

__ jmp(&end);

__ bind(&do_call);

- TypeofStub stub(isolate());

- CallCode(stub.GetCode(), RelocInfo::CODE_TARGET, instr);

+ Callable callable = CodeFactory::Typeof(isolate());

+ CallCode(callable.code(), RelocInfo::CODE_TARGET, instr);

__ bind(&end);

}