Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 219583003: Mojo: Move mojo/public/shell to mojo/public/{cpp,interfaces}/shell. (Closed)

Created:
6 years, 8 months ago by viettrungluu
Modified:
6 years, 8 months ago
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Mojo: Move mojo/public/shell to mojo/public/{cpp,interfaces}/shell. R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260627

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -350 lines) Patch
M mojo/apps/js/main.js View 1 chunk +1 line, -1 line 0 comments Download
M mojo/examples/aura_demo/aura_demo.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/examples/compositor_app/compositor_app.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/examples/launcher/launcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/examples/pepper_container_app/pepper_container_app.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/examples/sample_app/sample_app.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/examples/view_manager/view_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/mojo_public.gypi View 2 chunks +5 lines, -5 lines 0 comments Download
A mojo/public/cpp/shell/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
A + mojo/public/cpp/shell/application.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/public/cpp/shell/lib/application.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/public/cpp/shell/lib/service.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/public/cpp/shell/service.h View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/public/interfaces/shell/shell.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
D mojo/public/shell/application.h View 1 chunk +0 lines, -43 lines 0 comments Download
D mojo/public/shell/lib/application.cc View 1 chunk +0 lines, -54 lines 0 comments Download
D mojo/public/shell/lib/service.cc View 1 chunk +0 lines, -19 lines 0 comments Download
D mojo/public/shell/service.h View 1 chunk +0 lines, -184 lines 0 comments Download
D mojo/public/shell/shell.mojom View 1 chunk +0 lines, -19 lines 0 comments Download
M mojo/service_manager/service_loader.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/service_manager/service_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/service_manager/service_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/native_viewport/native_viewport_service.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/native_viewport/native_viewport_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/android/mojo_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/dynamic_service_loader.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/dynamic_service_runner.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
viettrungluu
6 years, 8 months ago (2014-03-31 16:41:44 UTC) #1
darin (slow to review)
LGTM
6 years, 8 months ago (2014-03-31 16:43:49 UTC) #2
viettrungluu
6 years, 8 months ago (2014-03-31 20:17:38 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 manually as r260627 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698