Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 219583002: DevTools: [CodeMirror] Implement "select next occurrence" functionality (Closed)

Created:
6 years, 8 months ago by lushnikov
Modified:
6 years, 8 months ago
Reviewers:
apavlov, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: [CodeMirror] Implement "select next occurrence" functionality This patch adds a Ctrl-D shortcut to the devtools editor which selects the next occurrence of word or selection. Implementation is based on CodeMirror v4 multiple cursor capabilities. BUG=356878 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170557

Patch Set 1 #

Patch Set 2 : add testcase #

Total comments: 2

Patch Set 3 : s/occurence/occurrence/ #

Patch Set 4 : do not use tokenHighlighter with multiple selections #

Unified diffs Side-by-side diffs Delta from patch set Stats (+473 lines, -17 lines) Patch
A LayoutTests/inspector/editor/text-editor-ctrl-d.html View 1 2 1 chunk +213 lines, -0 lines 0 comments Download
A LayoutTests/inspector/editor/text-editor-ctrl-d-expected.txt View 1 2 1 chunk +63 lines, -0 lines 0 comments Download
M Source/devtools/front_end/CodeMirrorTextEditor.js View 1 2 3 13 chunks +196 lines, -15 lines 0 comments Download
M Source/devtools/front_end/externs.js View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
lushnikov
Please, take a look
6 years, 8 months ago (2014-03-31 17:57:14 UTC) #1
apavlov
s/occurence/occurrence/gi lgtm otherwise https://codereview.chromium.org/219583002/diff/20001/LayoutTests/inspector/editor/text-editor-ctrl-d.html File LayoutTests/inspector/editor/text-editor-ctrl-d.html (right): https://codereview.chromium.org/219583002/diff/20001/LayoutTests/inspector/editor/text-editor-ctrl-d.html#newcode25 LayoutTests/inspector/editor/text-editor-ctrl-d.html:25: function nextOccurence(times) "occurrence" here and elsewhere ...
6 years, 8 months ago (2014-04-01 08:24:57 UTC) #2
lushnikov
Thanks, fixed grammar.
6 years, 8 months ago (2014-04-01 08:50:40 UTC) #3
lushnikov
The CQ bit was checked by lushnikov@chromium.org
6 years, 8 months ago (2014-04-01 08:50:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/219583002/40001
6 years, 8 months ago (2014-04-01 08:50:49 UTC) #5
lushnikov
The CQ bit was unchecked by lushnikov@chromium.org
6 years, 8 months ago (2014-04-01 09:01:46 UTC) #6
lushnikov
6 years, 8 months ago (2014-04-01 11:54:30 UTC) #7
lushnikov
The CQ bit was checked by lushnikov@chromium.org
6 years, 8 months ago (2014-04-01 11:55:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/219583002/60001
6 years, 8 months ago (2014-04-01 11:56:00 UTC) #9
commit-bot: I haz the power
6 years, 8 months ago (2014-04-01 13:05:03 UTC) #10
Message was sent while issue was closed. 
Change committed as 170557

Powered by Google App Engine
This is Rietveld 408576698