Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1007)

Issue 2195783002: Add explicit geolocation_java dependency for android_webview (Closed)

Created:
4 years, 4 months ago by mcasas
Modified:
4 years, 4 months ago
Reviewers:
boliu
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add explicit geolocation_java dependency for android_webview This CL addresses the problem in the bug, i.e. android webview not finding the Geolocation classes after moving to //device. BUG=632777 Committed: https://crrev.com/dd72bb32079cd40841cb9858a1afff6157c2427b Cr-Commit-Position: refs/heads/master@{#408757}

Patch Set 1 #

Patch Set 2 : typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M android_webview/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
mcasas
boliu@ PTAL
4 years, 4 months ago (2016-07-29 18:26:08 UTC) #3
boliu
lgtm % typo
4 years, 4 months ago (2016-07-29 18:29:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2195783002/40001
4 years, 4 months ago (2016-07-29 19:09:04 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 4 months ago (2016-07-29 21:18:59 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 21:20:11 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dd72bb32079cd40841cb9858a1afff6157c2427b
Cr-Commit-Position: refs/heads/master@{#408757}

Powered by Google App Engine
This is Rietveld 408576698