Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 2195773002: Rename EarlGrey test classes with TestCase suffix. (Closed)

Created:
4 years, 4 months ago by baxley
Modified:
4 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename EarlGrey test classes with TestCase suffix. They inherit from XCTestCase, so TestCase suffix makes it a bit more clear. BUG= Committed: https://crrev.com/1f82749d997f2f290e533d29cfb2bd15f98f54f4 Cr-Commit-Position: refs/heads/master@{#408708}

Patch Set 1 #

Patch Set 2 : after successful sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M ios/web/shell/test/meta_tags_egtest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/web/shell/test/navigation_egtest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/web/shell/test/page_state_egtest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/web/shell/test/pdf_egtest.mm View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ios/web/shell/test/plugin_placeholder_egtest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/web/shell/test/redirect_egtest.mm View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
baxley
4 years, 4 months ago (2016-07-29 18:24:18 UTC) #2
Eugene But (OOO till 7-30)
Thanks for cleanup. lgtm
4 years, 4 months ago (2016-07-29 18:27:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2195773002/20001
4 years, 4 months ago (2016-07-29 18:28:32 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-29 19:12:03 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 19:14:57 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1f82749d997f2f290e533d29cfb2bd15f98f54f4
Cr-Commit-Position: refs/heads/master@{#408708}

Powered by Google App Engine
This is Rietveld 408576698