Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2195713002: Properly recycle uniform buffers in vulkan (Closed)

Created:
4 years, 4 months ago by egdaniel
Modified:
4 years, 4 months ago
Reviewers:
jvanverth1, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@slownanobench
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Properly recycle uniform buffers in vulkan BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2195713002 Committed: https://skia.googlesource.com/skia/+/31bc7df59b2cafeaf13bc3cd44a1a3ba3c54308e

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -10 lines) Patch
M src/gpu/vk/GrVkBuffer.h View 2 chunks +10 lines, -5 lines 0 comments Download
M src/gpu/vk/GrVkBuffer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/vk/GrVkPipelineState.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/vk/GrVkUniformBuffer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/gpu/vk/GrVkUniformBuffer.cpp View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
egdaniel
This gets rid of most of the time we were seeing in creating uniform buffers.
4 years, 4 months ago (2016-07-29 15:09:04 UTC) #3
bsalomon
rs lgtm
4 years, 4 months ago (2016-07-29 16:26:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2195713002/20001
4 years, 4 months ago (2016-07-29 16:58:18 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 17:46:09 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/31bc7df59b2cafeaf13bc3cd44a1a3ba3c54308e

Powered by Google App Engine
This is Rietveld 408576698