Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2195683002: V8: Switch msan configurations to what chromium uses (Closed)

Created:
4 years, 4 months ago by Michael Achenbach
Modified:
4 years, 4 months ago
Reviewers:
tandrii(chromium)
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, jochen (gone - plz use gerrit), vogelheim
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M scripts/slave/recipe_modules/v8/builders.py View 2 chunks +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___arm64___sim___MSAN.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_msan_rel.json View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 13 (8 generated)
Michael Achenbach
PTAL - should be the same as: https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium_tests/chromium_lkgr.py?q=prebuilt_instrumented_libraries&sq=package:chromium&dr=C&l=329 The prebuilt_instrumented_libraries flag doesn't have an effect ...
4 years, 4 months ago (2016-07-29 11:28:41 UTC) #3
Michael Achenbach
https://codereview.chromium.org/2195683002/diff/1/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_msan_rel.json File scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_msan_rel.json (right): https://codereview.chromium.org/2195683002/diff/1/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_msan_rel.json#newcode151 scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_msan_rel.json:151: "GYP_DEFINES": "clang=1 dcheck_always_on=0 fastbuild=1 gomadir='[CACHE]/cipd/goma' msan=1 msan_track_origins=2 target_arch=x64 test_isolation_mode=prepare ...
4 years, 4 months ago (2016-07-29 11:30:36 UTC) #6
tandrii(chromium)
lgtm
4 years, 4 months ago (2016-07-29 11:31:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2195683002/1
4 years, 4 months ago (2016-07-29 11:36:46 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 11:40:03 UTC) #13
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/ee01216ab151053c9589...

Powered by Google App Engine
This is Rietveld 408576698