Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 2195603002: Create a character stream and hook it up to the parse info (Closed)

Created:
4 years, 4 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 4 months ago
Reviewers:
vogelheim, marja
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Create a character stream and hook it up to the parse info Also make it possible to use the background parser from a character stream. The External{One,Two}ByteStringUtf16CharacterStreams work both on foreground and background threads. BUG=v8:5215 R=marja@chromium.org,vogelheim@chromium.org Committed: https://crrev.com/84b07ec24d0cb9588dc22ca5f9b0f709afbf91fe Cr-Commit-Position: refs/heads/master@{#38162}

Patch Set 1 #

Patch Set 2 : updates #

Total comments: 2

Patch Set 3 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -7 lines) Patch
M src/compiler-dispatcher/compiler-dispatcher-job.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/compiler-dispatcher/compiler-dispatcher-job.cc View 1 3 chunks +23 lines, -2 lines 0 comments Download
M src/parsing/parser.h View 2 chunks +6 lines, -0 lines 0 comments Download
M src/parsing/parser.cc View 1 2 3 chunks +15 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
jochen (gone - plz use gerrit)
4 years, 4 months ago (2016-07-29 07:07:33 UTC) #1
marja
lgtm w/ comment https://codereview.chromium.org/2195603002/diff/20001/src/parsing/parser.cc File src/parsing/parser.cc (right): https://codereview.chromium.org/2195603002/diff/20001/src/parsing/parser.cc#newcode5491 src/parsing/parser.cc:5491: // When streaming, we don't know ...
4 years, 4 months ago (2016-07-29 08:43:52 UTC) #8
jochen (gone - plz use gerrit)
https://codereview.chromium.org/2195603002/diff/20001/src/parsing/parser.cc File src/parsing/parser.cc (right): https://codereview.chromium.org/2195603002/diff/20001/src/parsing/parser.cc#newcode5491 src/parsing/parser.cc:5491: // When streaming, we don't know the length of ...
4 years, 4 months ago (2016-07-29 08:54:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2195603002/30001
4 years, 4 months ago (2016-07-29 08:54:52 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:30001)
4 years, 4 months ago (2016-07-29 09:17:16 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 09:20:12 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/84b07ec24d0cb9588dc22ca5f9b0f709afbf91fe
Cr-Commit-Position: refs/heads/master@{#38162}

Powered by Google App Engine
This is Rietveld 408576698