Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3105)

Unified Diff: chrome/browser/resources/md_history/synced_device_card.js

Issue 2195593002: MD History: Fix clicking on synced tab links (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Whitespace Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/data/webui/md_history/history_synced_tabs_test.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/md_history/synced_device_card.js
diff --git a/chrome/browser/resources/md_history/synced_device_card.js b/chrome/browser/resources/md_history/synced_device_card.js
index da1f0f38a833ee746625d3476bcfe96cc3d023b3..d00e5c90e3f276aefb52c416d84d694aec542a88 100644
--- a/chrome/browser/resources/md_history/synced_device_card.js
+++ b/chrome/browser/resources/md_history/synced_device_card.js
@@ -35,8 +35,6 @@ Polymer({
searchTerm: String,
- windowId: Number,
-
sessionTag: String,
},
@@ -57,7 +55,7 @@ Polymer({
var model = /** @type {ForeignSessionTab} */(e.model);
calamity 2016/07/29 04:59:15 This annotation is also wrong. Make it var tab = /
tsergeant 2016/07/29 05:04:03 The closure trybot agrees with you. Done.
var srcEvent = /** @type {Event} */(e.detail.sourceEvent);
md_history.BrowserService.getInstance().openForeignSessionTab(
- this.sessionTag, model.windowId, model.sessionId, srcEvent);
+ this.sessionTag, model.tab.windowId, model.tab.sessionId, srcEvent);
e.preventDefault();
},
« no previous file with comments | « no previous file | chrome/test/data/webui/md_history/history_synced_tabs_test.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698