MD History: Fix clicking on synced tab links

MD History: Fix clicking on synced tab links

A small error in event handling code meant it was no longer possible to
click on synced tabs. This CL fixes the regression and adds a test.

BUG=632265
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/92d6c18fcb5614c9d3abc85ce54c1c619b42f535
Cr-Commit-Position: refs/heads/master@{#408586}

[tsergeant, 2016-07-29 04:53:15]

Description was changed from

==========
MD History: Fix clicking on synced tab links

A small error in event handling code meant it was no longer possible to
click on synced tabs. This CL fixes the regression and adds a test.

BUG=632265
==========

to

==========
MD History: Fix clicking on synced tab links

A small error in event handling code meant it was no longer possible to
click on synced tabs. This CL fixes the regression and adds a test.

BUG=632265
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2016-07-29 04:54:46]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[tsergeant, 2016-07-29 04:54:55]

tsergeant@chromium.org changed reviewers:
+ calamity@chromium.org

[commit-bot: I haz the power, 2016-07-29 04:54:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[calamity, 2016-07-29 04:59:15]

Thanks for fixing. lgtm.

https://codereview.chromium.org/2195593002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_history/synced_device_card.js (right):

https://codereview.chromium.org/2195593002/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_history/synced_device_card.js:55: var model = /**
@type {ForeignSessionTab} */(e.model);
This annotation is also wrong. Make it var tab = /** @type {ForeignSessionTab}
*/(e.model.tab); instead.

[commit-bot: I haz the power, 2016-07-29 05:02:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-29 05:02:51]

Dry run: Try jobs failed on following builders:
  closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)

[tsergeant, 2016-07-29 05:03:57]

The CQ bit was checked by tsergeant@chromium.org

[tsergeant, 2016-07-29 05:03:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
calamity@chromium.org
Link to the patchset: https://codereview.chromium.org/2195593002/#ps40001
(title: "Fix closure")

[tsergeant, 2016-07-29 05:04:04]

https://codereview.chromium.org/2195593002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_history/synced_device_card.js (right):

https://codereview.chromium.org/2195593002/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_history/synced_device_card.js:55: var model = /**
@type {ForeignSessionTab} */(e.model);
On 2016/07/29 04:59:15, calamity wrote:
> This annotation is also wrong. Make it var tab = /** @type {ForeignSessionTab}
> */(e.model.tab); instead.

The closure trybot agrees with you. Done.

[commit-bot: I haz the power, 2016-07-29 05:04:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 05:53:41]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-29 05:55:16]

Description was changed from

==========
MD History: Fix clicking on synced tab links

A small error in event handling code meant it was no longer possible to
click on synced tabs. This CL fixes the regression and adds a test.

BUG=632265
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD History: Fix clicking on synced tab links

A small error in event handling code meant it was no longer possible to
click on synced tabs. This CL fixes the regression and adds a test.

BUG=632265
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/92d6c18fcb5614c9d3abc85ce54c1c619b42f535
Cr-Commit-Position: refs/heads/master@{#408586}
==========

[commit-bot: I haz the power, 2016-07-29 05:55:18]

Patchset 3 (id:??) landed as
https://crrev.com/92d6c18fcb5614c9d3abc85ce54c1c619b42f535
Cr-Commit-Position: refs/heads/master@{#408586}