Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Issue 2195563002: Remove sign in preference in demo mode (Closed)

Created:
4 years, 4 months ago by Theresa
Modified:
4 years, 4 months ago
Reviewers:
Ted C
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove sign in preference in demo mode BUG=632379 Committed: https://crrev.com/39246f02cd0a853000b698416afe196da5e35f00 Cr-Commit-Position: refs/heads/master@{#408738}

Patch Set 1 #

Patch Set 2 : Remove sign in preference in demo mode #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -5 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java View 1 5 chunks +17 lines, -5 lines 0 comments Download

Messages

Total messages: 21 (14 generated)
Theresa
ptal
4 years, 4 months ago (2016-07-29 01:56:18 UTC) #3
Theresa
hold off on this review - I need to fix tests
4 years, 4 months ago (2016-07-29 16:02:31 UTC) #7
Theresa
ptal
4 years, 4 months ago (2016-07-29 17:58:37 UTC) #12
Ted C
lgtm
4 years, 4 months ago (2016-07-29 19:31:51 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2195563002/20001
4 years, 4 months ago (2016-07-29 19:48:01 UTC) #17
commit-bot: I haz the power
Failed to apply the patch.
4 years, 4 months ago (2016-07-29 21:03:48 UTC) #19
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 21:04:42 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/39246f02cd0a853000b698416afe196da5e35f00
Cr-Commit-Position: refs/heads/master@{#408738}

Powered by Google App Engine
This is Rietveld 408576698