Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 2195543002: Check for FROM_EXIT in TabModelGetLastId(). (Closed)

Created:
4 years, 4 months ago by aelias_OOO_until_Jul13
Modified:
4 years, 4 months ago
Reviewers:
Ted C
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check for FROM_EXIT in TabModelGetLastId(). This early return is meant to avoid storing the last ID for a tab which is about to be destroyed. The behavior should logically apply equally to FROM_CLOSE and FROM_EXIT, but by an oversight, only FROM_CLOSE was checked. BUG=629080 Committed: https://crrev.com/6142431d9ae6958070e0ef8264549b9ead705dd9 Cr-Commit-Position: refs/heads/master@{#408701}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelImpl.java View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 15 (10 generated)
aelias_OOO_until_Jul13
Hi Ted, PTAL. I haven't yet 100% understood the sequence of events causing the blank ...
4 years, 4 months ago (2016-07-29 01:47:02 UTC) #6
Ted C
lgtm
4 years, 4 months ago (2016-07-29 18:45:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2195543002/1
4 years, 4 months ago (2016-07-29 18:48:26 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-29 18:52:23 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 18:53:54 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6142431d9ae6958070e0ef8264549b9ead705dd9
Cr-Commit-Position: refs/heads/master@{#408701}

Powered by Google App Engine
This is Rietveld 408576698