Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2195533003: Enable chrome.certificateProvider API on the login screen (Closed)

Created:
4 years, 4 months ago by emaxx
Modified:
4 years, 4 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable chrome.certificateProvider API on the login screen This turns on the chrome.certificateProvider API for the login screen apps by allowing to create the CertificateProviderService for the signin profile. BUG=632728 TEST=manual (install a smart card app on the login screen and go through SAML login with an IdP page that requires the client certificate) Committed: https://crrev.com/78a03b949912a688a808c0d3624d78d82672db9f Cr-Commit-Position: refs/heads/master@{#408639}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M chrome/browser/chromeos/certificate_provider/certificate_provider_service_factory.cc View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
emaxx
Xiyuan, PTAL.
4 years, 4 months ago (2016-07-29 14:33:45 UTC) #5
xiyuan
lgtm
4 years, 4 months ago (2016-07-29 15:19:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2195533003/1
4 years, 4 months ago (2016-07-29 15:20:36 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-29 15:23:28 UTC) #12
emaxx
On 2016/07/29 15:19:04, xiyuan wrote: > lgtm Thanks for the quick review!
4 years, 4 months ago (2016-07-29 15:24:04 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 15:26:12 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/78a03b949912a688a808c0d3624d78d82672db9f
Cr-Commit-Position: refs/heads/master@{#408639}

Powered by Google App Engine
This is Rietveld 408576698