predictors: Add the request priority to the reource_prefetch_predictor DB.

predictors: Add the request priority to the resource_prefetch_predictor DB.

Request priority is derived from the priority given by Blink. This makes
it an important criteria for prioritizing requests in prefetch.
This CL stores the request priority in the local database. A forthcoming
one will use it for prioritization.

BUG=631966
Committed: https://crrev.com/6e3614acd196b31a68c1f1f1a90804379cae57d1
Cr-Commit-Position: refs/heads/master@{#409180}

[Benoit L, 2016-07-29 16:01:30]

lizeb@chromium.org changed reviewers:
+ pasko@chromium.org

[Benoit L, 2016-07-29 16:01:31]

Sorry about the large diff, it's due to tests updates, and to "git cl format". I
figured that it's better to let "git cl format" do whatever it prefers rather
than fighting it.
Resistance is futile. You will be assimilated.

[pasko, 2016-07-29 17:13:11]

lgtm

but but .. isn't it possible to send a git cl format as a separate change?

[pasko, 2016-07-29 17:13:32]

https://codereview.chromium.org/2195503003/diff/1/chrome/browser/predictors/r...
File chrome/browser/predictors/resource_prefetch_predictor_tables.cc (right):

https://codereview.chromium.org/2195503003/diff/1/chrome/browser/predictors/r...
chrome/browser/predictors/resource_prefetch_predictor_tables.cc:126: //
TODO(lizeb): Take priority into account.
is it obvious that this should be done? :)
I think a bug works better than a TODO, there are a few details we may want to
discuss about it

[Benoit L, 2016-07-30 12:21:17]

The CQ bit was checked by lizeb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-30 12:21:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-30 12:30:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-30 12:30:18]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[Benoit L, 2016-08-01 10:06:18]

The CQ bit was checked by lizeb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-01 10:06:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-01 10:48:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-01 10:48:07]

Dry run: This issue passed the CQ dry run.

[Benoit L, 2016-08-01 11:26:34]

lizeb@chromium.org changed reviewers:
+ battre@chromium.org

[Benoit L, 2016-08-01 11:26:35]

Hi battre@

Can you take a look at the one-line change in
chrome/browser/net/resource_prefetch_predictor_observer.cc? 

Thanks!

[Benoit L, 2016-08-01 11:26:53]

Description was changed from

==========
predictors: Add the request priority to the reource_prefetch_predictor DB.

Request priority is derived from the priority given by Blink. This makes
it an important criteria for prioritizing requests in prefetch.
This CL stores the request priority in the local database. A forthcoming
one will use it for prioritization.

BUG=631966
==========

to

==========
predictors: Add the request priority to the resource_prefetch_predictor DB.

Request priority is derived from the priority given by Blink. This makes
it an important criteria for prioritizing requests in prefetch.
This CL stores the request priority in the local database. A forthcoming
one will use it for prioritization.

BUG=631966
==========

[battre, 2016-08-02 12:55:18]

chrome/browser/net/resource_prefetch_predictor_observer.cc LGTM

[Benoit L, 2016-08-02 12:56:26]

The CQ bit was checked by lizeb@chromium.org

[Benoit L, 2016-08-02 12:56:26]

The patchset sent to the CQ was uploaded after l-g-t-m from pasko@chromium.org
Link to the patchset: https://codereview.chromium.org/2195503003/#ps20001
(title: "Compile fix.")

[commit-bot: I haz the power, 2016-08-02 12:56:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 13:38:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-02 13:39:43]

Description was changed from

==========
predictors: Add the request priority to the resource_prefetch_predictor DB.

Request priority is derived from the priority given by Blink. This makes
it an important criteria for prioritizing requests in prefetch.
This CL stores the request priority in the local database. A forthcoming
one will use it for prioritization.

BUG=631966
==========

to

==========
predictors: Add the request priority to the resource_prefetch_predictor DB.

Request priority is derived from the priority given by Blink. This makes
it an important criteria for prioritizing requests in prefetch.
This CL stores the request priority in the local database. A forthcoming
one will use it for prioritization.

BUG=631966

Committed: https://crrev.com/6e3614acd196b31a68c1f1f1a90804379cae57d1
Cr-Commit-Position: refs/heads/master@{#409180}
==========

[commit-bot: I haz the power, 2016-08-02 13:39:44]

Patchset 2 (id:??) landed as
https://crrev.com/6e3614acd196b31a68c1f1f1a90804379cae57d1
Cr-Commit-Position: refs/heads/master@{#409180}