Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2195503002: chrome/browser/metrics: Change auto to not deduce raw pointers. (Closed)

Created:
4 years, 4 months ago by vmpstr
Modified:
4 years, 4 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, danakj
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chrome/browser/metrics: Change auto to not deduce raw pointers. This patch updates the code to prevent auto deducing to a raw pointer. R=asvitkine@chromium.org BUG=554600 Committed: https://crrev.com/418dc6a24457bcb6c2c8ffdd95f5993c7e3e05de Cr-Commit-Position: refs/heads/master@{#408761}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/browser/metrics/leak_detector/leak_detector_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/perf/cpu_identity.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
vmpstr
Please take a look.
4 years, 4 months ago (2016-07-28 23:43:16 UTC) #1
Alexei Svitkine (slow)
lgtm
4 years, 4 months ago (2016-07-29 19:38:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2195503002/1
4 years, 4 months ago (2016-07-29 19:39:20 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-29 21:22:02 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 21:24:42 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/418dc6a24457bcb6c2c8ffdd95f5993c7e3e05de
Cr-Commit-Position: refs/heads/master@{#408761}

Powered by Google App Engine
This is Rietveld 408576698