[Findit] Dashboards and graph for regression range

appengine/findit/handlers/flake/test/check_flake_test.py

Index: appengine/findit/handlers/flake/test/check_flake_test.py
diff --git a/appengine/findit/handlers/flake/test/check_flake_test.py b/appengine/findit/handlers/flake/test/check_flake_test.py
index f36aa7673b5e1959d5c5b2dae5849a47e594bbe4..01e1059e35daedf20d1fb60b8bea25ed2bf58da7 100644
--- a/appengine/findit/handlers/flake/test/check_flake_test.py
+++ b/appengine/findit/handlers/flake/test/check_flake_test.py
@@ -5,6 +5,8 @@
 import webapp2
 
 from handlers.flake import check_flake
+from model.flake.master_flake_analysis import MasterFlakeAnalysis
+from model import analysis_status
 from waterfall.test import wf_testcase
 
 
@@ -13,7 +15,16 @@ class CheckFlakeTest(wf_testcase.WaterfallTestCase):
       ('/waterfall/check-flake', check_flake.CheckFlake),
   ], debug=True)
 
-  def testBasicFlow(self):
+  def _CreateAndSaveMasterFlakeAnalysis(
+      self, master_name, builder_name, build_number,
+      step_name, test_name, status):
+    analysis = MasterFlakeAnalysis.Create(
+        master_name, builder_name, build_number, step_name, test_name)
+    analysis.status = status
+    analysis.put()
+    return analysis
+
+  def testBasicFlowNoData(self):
     master_name = 'm'
     builder_name = 'b'
     build_number = '123'
@@ -28,4 +39,37 @@ class CheckFlakeTest(wf_testcase.WaterfallTestCase):
         'build_number': build_number,
         'step_name': step_name,
         'test_name': test_name})
+
+    self.assertEquals(200, response.status_int)
+
+  def testBasicFlowWithData(self):
+    master_name = 'm'
+    builder_name = 'b'
+    build_number = '123'
+    step_name = 's'
+    test_name = 't'
+
+    status = analysis_status.PENDING
+
+    master_flake_analysis = self._CreateAndSaveMasterFlakeAnalysis(
+        master_name, builder_name, build_number, step_name,
+        test_name, status)
+    master_flake_analysis.build_numbers.append(123)

[lijeffrey, 2016/08/02 21:21:51]

nit: use int(build_number)

[caiw, 2016/08/02 21:47:06]

Done.

+    master_flake_analysis.success_rates.append(.9)

[lijeffrey, 2016/08/02 21:21:51]

nit: make 0.9 a variable called success_rate then reference it here and in
expected_check_flake_result

[caiw, 2016/08/02 21:47:06]

Done.

+    master_flake_analysis.put()
+
+    self.mock_current_user(user_email='test@chromium.org', is_admin=True)
+
+    response = self.test_app.get('/waterfall/check-flake', params={
+        'master_name': master_name,
+        'builder_name': builder_name,
+        'build_number': build_number,
+        'step_name': step_name,
+        'test_name': test_name,
+        'format': 'json'})
+
     self.assertEquals(200, response.status_int)
+    expected_check_flake_result ={
+        'success_rates': [[123,0.9]]

[lijeffrey, 2016/08/02 21:21:51]

nit: space after ,

[caiw, 2016/08/02 21:47:06]

Done.

+    }
+    self.assertEqual(expected_check_flake_result, response.json_body)