Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Unified Diff: appengine/findit/handlers/flake/check_flake.py

Issue 2195473002: [Findit] Dashboards and graph for regression range (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/handlers/flake/check_flake.py
diff --git a/appengine/findit/handlers/flake/check_flake.py b/appengine/findit/handlers/flake/check_flake.py
index 0390b09634037d338fe2fdf1f89838dd28fc4be3..6ea6d9f553d31394dae5adfb1e261574b4adfead 100644
--- a/appengine/findit/handlers/flake/check_flake.py
+++ b/appengine/findit/handlers/flake/check_flake.py
@@ -19,14 +19,22 @@ class CheckFlake(BaseHandler):
master_name = self.request.get('master_name').strip()
builder_name = self.request.get('builder_name').strip()
build_number = int(self.request.get('build_number').strip())
- step_name = self.request.get('test_target_name').strip()
+ step_name = self.request.get('step_name').strip()
test_name = self.request.get('test_name').strip()
force = (users.is_current_user_admin() and
self.request.get('force') == '1')
- ScheduleAnalysisIfNeeded(master_name, builder_name, build_number, step_name,
- test_name, force=force,
- queue_name=constants.WATERFALL_ANALYSIS_QUEUE)
+ master_flake_analysis = ScheduleAnalysisIfNeeded(
+ master_name, builder_name, build_number, step_name,
+ test_name, force=force, queue_name=constants.WATERFALL_ANALYSIS_QUEUE)
+
+ data = {}
lijeffrey 2016/07/29 00:22:55 you can make this data = { 'success_rates' =
caiw 2016/07/29 23:20:51 Done.
+ data['success_rates'] = []
+ for (b_n, s_r) in zip(
lijeffrey 2016/07/29 00:22:55 nit: better to spell out these variables for reada
caiw 2016/07/29 23:20:51 Done.
+ master_flake_analysis.build_numbers,
+ master_flake_analysis.success_rates):
+ data['success_rates'].append([b_n, s_r])
return {
- 'template': 'flake/result.html'
+ 'template': 'flake/result.html',
+ 'data': data
}
« no previous file with comments | « no previous file | appengine/findit/handlers/flake/flake_dashboard.py » ('j') | appengine/findit/handlers/flake/flake_dashboard.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698