Fix so that logic to enable private user define @JS classes does not impact codegen for dart:html n…

Fix so that logic to enable private user define @JS classes does not impact codegen for dart:html native classes where private classes are not an issue.

BUG=
R=alanknight@google.com

Committed: https://github.com/dart-lang/sdk/commit/7f2950916ecf6d3c9d77858b621c9591135f2c92

[Jacob, 2016-07-28 21:30:16]

jacobr@google.com changed reviewers:
+ alanknight@google.com, terry@google.com

[Alan Knight, 2016-08-03 20:57:39]

lgtm

[Jacob, 2016-08-03 21:03:45]

Description was changed from

==========
Fix so that logic to enable private user define @JS classes does not impact
codegen for dart:html native classes where private classes are not an issue.

BUG=
==========

to

==========
Fix so that logic to enable private user define @JS classes does not impact
codegen for dart:html native classes where private classes are not an issue.

BUG=
R=alanknight@google.com

Committed:
https://github.com/dart-lang/sdk/commit/7f2950916ecf6d3c9d77858b621c9591135f2c92
==========

[Jacob, 2016-08-03 21:03:46]

Committed patchset #2 (id:20001) manually as
7f2950916ecf6d3c9d77858b621c9591135f2c92 (presubmit successful).

[terry, 2016-08-04 13:50:34]

This doesn't require a regen of Dartium patch files?

https://codereview.chromium.org/2195453002/diff/20001/sdk/lib/js/dartium/js_d...
File sdk/lib/js/dartium/js_dartium.dart (right):

https://codereview.chromium.org/2195453002/diff/20001/sdk/lib/js/dartium/js_d...
sdk/lib/js/dartium/js_dartium.dart:719: if (isPrivateUserDefinedClass) {
I'm assuming this should not happen?  Are there class names in dart: libraries
with a _className that's a DOM class?

[terry, 2016-08-04 13:58:21]

https://codereview.chromium.org/2195453002/diff/20001/sdk/lib/js/dartium/js_d...
File sdk/lib/js/dartium/js_dartium.dart (right):

https://codereview.chromium.org/2195453002/diff/20001/sdk/lib/js/dartium/js_d...
sdk/lib/js/dartium/js_dartium.dart:719: if (isPrivateUserDefinedClass) {
On 2016/08/04 13:50:33, terry wrote:
> I'm assuming this should not happen?  Are there class names in dart: libraries
> with a _className that's a DOM class?

Looks like there are classes in dart: with underscore that are DomName so I
suspect we'll need to regen the patch files for dartium?

[terry, 2016-08-04 14:26:41]

I re-gen'd patch files and didn't see any change :-/