Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2195443002:
Add a histogram: Media.AVDA.NumAVDAInstances (Closed)
|
Created:
4 years, 4 months ago by watk Modified:
4 years, 4 months ago CC:
chromium-reviews, posciak+watch_chromium.org, piman+watch_chromium.org, asvitkine+watch_chromium.org, feature-media-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd a histogram: Media.AVDA.NumAVDAInstances
NumAVDAInstances records the number of concurrently running
AndroidVideoDecodeAccelerators which is effectively equivalent to the
number of allocated MediaCodecs.
BUG=632459
Committed: https://crrev.com/c530313fcf3c4bb922317e2577136d3b68b52882
Cr-Commit-Position: refs/heads/master@{#409394}
Patch Set 1 #
Total comments: 4
Patch Set 2 : Use ENUM & add units #
Messages
Total messages: 29 (17 generated)
The CQ bit was checked by watk@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
watk@chromium.org changed reviewers: + liberato@chromium.org
Description was changed from ========== Add a histogram Media.AVDA.NumAVDAInstances NumAVDAInstances records the number of concurrently running AndroidVideoDecodeAccelerators which is effectively equivalent to the number of allocated MediaCodecs. BUG=632459 ========== to ========== Add a histogram Media.AVDA.NumAVDAInstances NumAVDAInstances records the number of concurrently running AndroidVideoDecodeAccelerators which is effectively equivalent to the number of allocated MediaCodecs. BUG=632459 ==========
Description was changed from ========== Add a histogram Media.AVDA.NumAVDAInstances NumAVDAInstances records the number of concurrently running AndroidVideoDecodeAccelerators which is effectively equivalent to the number of allocated MediaCodecs. BUG=632459 ========== to ========== Add a histogram: Media.AVDA.NumAVDAInstances NumAVDAInstances records the number of concurrently running AndroidVideoDecodeAccelerators which is effectively equivalent to the number of allocated MediaCodecs. BUG=632459 ==========
watk@chromium.org changed reviewers: + rkaplow@chromium.org
+rkaplow for histograms.xml
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
sorry, missed this. lgtm.
sorry, missed this. lgtm.
https://codereview.chromium.org/2195443002/diff/1/media/gpu/android_video_dec... File media/gpu/android_video_decode_accelerator.cc (right): https://codereview.chromium.org/2195443002/diff/1/media/gpu/android_video_dec... media/gpu/android_video_decode_accelerator.cc:197: UMA_HISTOGRAM_CUSTOM_COUNTS("Media.AVDA.NumAVDAInstances", This would be better by using the ENUM macro, like UMA_HISTOGRAM_ENUMERATION(name, sample, 21) since the default numeric macro does exponential sized buckets. https://codereview.chromium.org/2195443002/diff/1/tools/metrics/histograms/hi... File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2195443002/diff/1/tools/metrics/histograms/hi... tools/metrics/histograms/histograms.xml:21742: +<histogram name="Media.AVDA.NumAVDAInstances"> can you add a unit (presumably something like "accelerators")
The CQ bit was checked by watk@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #2 (id:20001) has been deleted
https://codereview.chromium.org/2195443002/diff/1/media/gpu/android_video_dec... File media/gpu/android_video_decode_accelerator.cc (right): https://codereview.chromium.org/2195443002/diff/1/media/gpu/android_video_dec... media/gpu/android_video_decode_accelerator.cc:197: UMA_HISTOGRAM_CUSTOM_COUNTS("Media.AVDA.NumAVDAInstances", On 2016/07/29 20:31:58, rkaplow wrote: > This would be better by using the ENUM macro, like > UMA_HISTOGRAM_ENUMERATION(name, sample, 21) > > since the default numeric macro does exponential sized buckets. Good to know. Done. https://codereview.chromium.org/2195443002/diff/1/tools/metrics/histograms/hi... File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2195443002/diff/1/tools/metrics/histograms/hi... tools/metrics/histograms/histograms.xml:21742: +<histogram name="Media.AVDA.NumAVDAInstances"> On 2016/07/29 20:31:58, rkaplow wrote: > can you add a unit (presumably something like "accelerators") Added "AVDA instances"
lgtm
The CQ bit was checked by watk@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from liberato@chromium.org Link to the patchset: https://codereview.chromium.org/2195443002/#ps40001 (title: "Use ENUM & add units")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by watk@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add a histogram: Media.AVDA.NumAVDAInstances NumAVDAInstances records the number of concurrently running AndroidVideoDecodeAccelerators which is effectively equivalent to the number of allocated MediaCodecs. BUG=632459 ========== to ========== Add a histogram: Media.AVDA.NumAVDAInstances NumAVDAInstances records the number of concurrently running AndroidVideoDecodeAccelerators which is effectively equivalent to the number of allocated MediaCodecs. BUG=632459 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Add a histogram: Media.AVDA.NumAVDAInstances NumAVDAInstances records the number of concurrently running AndroidVideoDecodeAccelerators which is effectively equivalent to the number of allocated MediaCodecs. BUG=632459 ========== to ========== Add a histogram: Media.AVDA.NumAVDAInstances NumAVDAInstances records the number of concurrently running AndroidVideoDecodeAccelerators which is effectively equivalent to the number of allocated MediaCodecs. BUG=632459 Committed: https://crrev.com/c530313fcf3c4bb922317e2577136d3b68b52882 Cr-Commit-Position: refs/heads/master@{#409394} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/c530313fcf3c4bb922317e2577136d3b68b52882 Cr-Commit-Position: refs/heads/master@{#409394} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
