Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2195403002: Add libplatform deps file (Closed)

Created:
4 years, 4 months ago by mattloring
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add libplatform deps file Add deps file allowing libplatform.h to include v8-tracing.h. Additionally removes redundant include/ that was causing build errors for node-lkgr. BUG= Committed: https://crrev.com/292cebc58bc827992c43a6a0f9e6f3887b3c1f30 Cr-Commit-Position: refs/heads/master@{#38217}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
A include/libplatform/DEPS View 1 chunk +5 lines, -0 lines 0 comments Download
M include/libplatform/libplatform.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
mattloring
4 years, 4 months ago (2016-08-01 15:39:18 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 4 months ago (2016-08-01 15:48:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2195403002/1
4 years, 4 months ago (2016-08-01 16:15:42 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-01 16:17:43 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 16:21:08 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/292cebc58bc827992c43a6a0f9e6f3887b3c1f30
Cr-Commit-Position: refs/heads/master@{#38217}

Powered by Google App Engine
This is Rietveld 408576698