Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Issue 2195393002: GN: define fake-gamma configuration to match our bots. (Closed)

Created:
4 years, 4 months ago by mtklein_C
Modified:
4 years, 4 months ago
Reviewers:
bungeman-skia
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

GN: define fake-gamma configuration to match our bots. This should fix many of the GN text diffs in Gold. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2195393002 Committed: https://skia.googlesource.com/skia/+/9be6866e95127b3ad55badfecd471f67e6f4612b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
mtklein_C
Sadly no trybots to test this yet.
4 years, 4 months ago (2016-08-01 15:21:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2195393002/1
4 years, 4 months ago (2016-08-01 15:21:50 UTC) #5
bungeman-skia
lgtm
4 years, 4 months ago (2016-08-01 15:23:16 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 15:37:53 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/9be6866e95127b3ad55badfecd471f67e6f4612b

Powered by Google App Engine
This is Rietveld 408576698