Chromium Code Reviews

Issue 2195373002: [test] Remove some deprecated test-runner variant shortcuts (Closed)

Created:
4 years, 4 months ago by Michael Achenbach
Modified:
4 years, 4 months ago
Reviewers:
Michael Starzinger, Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Remove some deprecated test-runner variant shortcuts It should be enough to specify --variants=... with the desired set of variants. The stress/nostress shortcuts might get confusing soon, as we intend to move the stress option out of the developer default set. BUG=v8:5238 Committed: https://crrev.com/0e988e4737e88c838241deb6b6fe8d2692015fa5 Cr-Commit-Position: refs/heads/master@{#38248}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Stats (+2 lines, -16 lines)
M tools/run-tests.py View 3 chunks +2 lines, -16 lines 1 comment

Messages

Total messages: 14 (9 generated)
Michael Achenbach
PTAL https://codereview.chromium.org/2195373002/diff/1/tools/run-tests.py File tools/run-tests.py (right): https://codereview.chromium.org/2195373002/diff/1/tools/run-tests.py#newcode546 tools/run-tests.py:546: VARIANTS = ["default", "stress"] I'm also not so ...
4 years, 4 months ago (2016-08-01 15:05:50 UTC) #3
Michael Starzinger
LGTM.
4 years, 4 months ago (2016-08-01 15:09:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2195373002/1
4 years, 4 months ago (2016-08-02 13:59:19 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-02 14:00:58 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 14:03:57 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0e988e4737e88c838241deb6b6fe8d2692015fa5
Cr-Commit-Position: refs/heads/master@{#38248}

Powered by Google App Engine