|
|
Created:
4 years, 4 months ago by Michael Achenbach Modified:
4 years, 4 months ago Reviewers:
Michael Starzinger, Jakob Kummerow CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[test] Remove some deprecated test-runner variant shortcuts
It should be enough to specify --variants=... with the
desired set of variants. The stress/nostress shortcuts
might get confusing soon, as we intend to move the stress
option out of the developer default set.
BUG=v8:5238
Committed: https://crrev.com/0e988e4737e88c838241deb6b6fe8d2692015fa5
Cr-Commit-Position: refs/heads/master@{#38248}
Patch Set 1 #
Total comments: 1
Created: 4 years, 4 months ago
Messages
Total messages: 14 (9 generated)
Description was changed from ========== [test] Remove some deprecated test-runner variant shortcuts BUG= ========== to ========== [test] Remove some deprecated test-runner variant shortcuts It should be enough to specify --variants=... with the desired set of variants. The stress/nostress shortcuts might get confusing soon, as we intend to move the stress option out of the developer default set. BUG=v8:5238 ==========
machenbach@chromium.org changed reviewers: + jkummerow@chromium.org, mstarzinger@chromium.org
PTAL https://codereview.chromium.org/2195373002/diff/1/tools/run-tests.py File tools/run-tests.py (right): https://codereview.chromium.org/2195373002/diff/1/tools/run-tests.py#newcode546 tools/run-tests.py:546: VARIANTS = ["default", "stress"] I'm also not so happy about this anymore, but I'll think about it in a separate CL.
LGTM.
The CQ bit was checked by machenbach@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [test] Remove some deprecated test-runner variant shortcuts It should be enough to specify --variants=... with the desired set of variants. The stress/nostress shortcuts might get confusing soon, as we intend to move the stress option out of the developer default set. BUG=v8:5238 ========== to ========== [test] Remove some deprecated test-runner variant shortcuts It should be enough to specify --variants=... with the desired set of variants. The stress/nostress shortcuts might get confusing soon, as we intend to move the stress option out of the developer default set. BUG=v8:5238 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [test] Remove some deprecated test-runner variant shortcuts It should be enough to specify --variants=... with the desired set of variants. The stress/nostress shortcuts might get confusing soon, as we intend to move the stress option out of the developer default set. BUG=v8:5238 ========== to ========== [test] Remove some deprecated test-runner variant shortcuts It should be enough to specify --variants=... with the desired set of variants. The stress/nostress shortcuts might get confusing soon, as we intend to move the stress option out of the developer default set. BUG=v8:5238 Committed: https://crrev.com/0e988e4737e88c838241deb6b6fe8d2692015fa5 Cr-Commit-Position: refs/heads/master@{#38248} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/0e988e4737e88c838241deb6b6fe8d2692015fa5 Cr-Commit-Position: refs/heads/master@{#38248} |