Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1002)

Issue 2195313003: [heap] Give marking functions for incremental marking more precise names. (Closed)

Created:
4 years, 4 months ago by Hannes Payer (out of office)
Modified:
4 years, 4 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Give marking functions for incremental marking more precise names. BUG= Committed: https://crrev.com/1575072c06fbdc4e67c7b446f20a7abc373cc33f Cr-Commit-Position: refs/heads/master@{#38230}

Patch Set 1 #

Patch Set 2 : fix compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -22 lines) Patch
M src/heap/heap.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/heap/incremental-marking.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M src/heap/incremental-marking.cc View 1 6 chunks +17 lines, -19 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
ulan
lgtm
4 years, 4 months ago (2016-08-01 16:50:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2195313003/1
4 years, 4 months ago (2016-08-01 19:47:38 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/builds/5976) v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED, ...
4 years, 4 months ago (2016-08-01 19:48:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2195313003/1
4 years, 4 months ago (2016-08-02 07:05:26 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/21899) v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, ...
4 years, 4 months ago (2016-08-02 07:06:37 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2195313003/20001
4 years, 4 months ago (2016-08-02 07:20:16 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-02 07:43:25 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 07:46:24 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1575072c06fbdc4e67c7b446f20a7abc373cc33f
Cr-Commit-Position: refs/heads/master@{#38230}

Powered by Google App Engine
This is Rietveld 408576698