Chromium Code Reviews| Index: media/base/sample_format.cc |
| diff --git a/media/base/sample_format.cc b/media/base/sample_format.cc |
| index 3fdcf1018e03475a20ad0e38e2ecc6a041d8ad49..5fbb02385ac055671e20f197a2f6cd6b34eb3345 100644 |
| --- a/media/base/sample_format.cc |
| +++ b/media/base/sample_format.cc |
| @@ -29,4 +29,28 @@ int SampleFormatToBytesPerChannel(SampleFormat sample_format) { |
| return 0; |
| } |
| +const char* SampleFormatToString(SampleFormat sample_format) { |
| + switch(sample_format) { |
| + case kUnknownSampleFormat: |
| + return "UNKNOWN_SAMPLE_FORMAT"; |
|
DaleCurtis
2013/08/05 22:16:54
Is this the style you want? Not say, "Unknown", "8
Ty Overby
2013/08/05 22:23:29
I like yours more.
Done.
|
| + case kSampleFormatU8: |
| + return "U8"; |
| + case kSampleFormatS16: |
| + return "S16"; |
| + case kSampleFormatS32: |
| + return "S32"; |
| + case kSampleFormatF32: |
| + return "F32"; |
| + case kSampleFormatPlanarS16: |
| + return "PLANAR S16"; |
| + case kSampleFormatPlanarF32: |
| + return "PLANAR F32"; |
| + case kSampleFormatMax: |
|
DaleCurtis
2013/08/05 22:16:54
Just break here and rely on the NOTREACHED() below
Ty Overby
2013/08/05 22:23:29
Done.
|
| + NOTREACHED() << "Invalid sample format provided: " << sample_format; |
| + break; |
| + } |
| + NOTREACHED() << "Invalid sample format provided: " << sample_format; |
| + return ""; |
| +} |
| + |
| } // namespace media |