Added logging calls to FFmpegDemuxer.

media/base/media_log.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/base/media_log.h"
 
 #include <string>
 
 #include "base/atomic_sequence_num.h"
 #include "base/logging.h"
@@ skipping 38 matching lines @@
     case MediaLogEvent::AUDIO_ENDED:
       return "AUDIO_ENDED";
     case MediaLogEvent::VIDEO_ENDED:
       return "VIDEO_ENDED";
     case MediaLogEvent::AUDIO_RENDERER_DISABLED:
       return "AUDIO_RENDERER_DISABLED";
     case MediaLogEvent::BUFFERED_EXTENTS_CHANGED:
       return "BUFFERED_EXTENTS_CHANGED";
     case MediaLogEvent::MEDIA_SOURCE_ERROR:
       return "MEDIA_SOURCE_ERROR";
+    case MediaLogEvent::PROPERTY_CHANGE:
+      return "PROPERTY_CHANGE";
   }
   NOTREACHED();
   return NULL;
 }
 
 const char* MediaLog::PipelineStatusToString(PipelineStatus status) {
   switch (status) {
     case PIPELINE_OK:
       return "pipeline: ok";
     case PIPELINE_ERROR_URL_NOT_FOUND:
@@ skipping 102 matching lines @@
 }
 
 scoped_ptr<MediaLogEvent> MediaLog::CreateVideoSizeSetEvent(
     size_t width, size_t height) {
   scoped_ptr<MediaLogEvent> event(CreateEvent(MediaLogEvent::VIDEO_SIZE_SET));
   event->params.SetInteger("width", width);
   event->params.SetInteger("height", height);
   return event.Pass();
 }
 
+void MediaLog::SetProperty(

[scherkus (not reviewing), 2013/08/02 21:53:48]

these should be SetString/Integer/Double/Boolean as overloading method names is
frowned upon (e.g., that bug you hit where it picked the wrong type when using
const char*)

[Ty Overby, 2013/08/02 23:04:27]

Done.

+    const char* key, const std::string& value) {
+  scoped_ptr<MediaLogEvent> event(CreateEvent(MediaLogEvent::PROPERTY_CHANGE));
+  event->params.SetString(key, value);
+  AddEvent(event.Pass());
+}
+
+void MediaLog::SetProperty(
+    const char* key, int value) {
+  scoped_ptr<MediaLogEvent> event(CreateEvent(MediaLogEvent::PROPERTY_CHANGE));
+  event->params.SetInteger(key, value);
+  AddEvent(event.Pass());
+}
+
+void MediaLog::SetProperty(
+    const char* key, double value) {
+  scoped_ptr<MediaLogEvent> event(CreateEvent(MediaLogEvent::PROPERTY_CHANGE));
+  event->params.SetDouble(key, value);
+  AddEvent(event.Pass());
+}
+
+void MediaLog::SetProperty(
+    const char* key, bool value) {
+  scoped_ptr<MediaLogEvent> event(CreateEvent(MediaLogEvent::PROPERTY_CHANGE));
+  event->params.SetBoolean(key, value);
+  AddEvent(event.Pass());
+}
+
+void MediaLog::SetProperty(
+    const char* key, Value* value) {

[scherkus (not reviewing), 2013/08/02 21:53:48]

FYI you're not calling this method -- remove?

[Ty Overby, 2013/08/02 23:04:27]

Done.

+  scoped_ptr<MediaLogEvent> event(CreateEvent(MediaLogEvent::PROPERTY_CHANGE));
+  event->params.Set(key, value);
+  AddEvent(event.Pass());
+}
+
 scoped_ptr<MediaLogEvent> MediaLog::CreateBufferedExtentsChangedEvent(
     int64 start, int64 current, int64 end) {
   scoped_ptr<MediaLogEvent> event(
       CreateEvent(MediaLogEvent::BUFFERED_EXTENTS_CHANGED));
   // These values are headed to JS where there is no int64 so we use a double
   // and accept loss of precision above 2^53 bytes (8 Exabytes).
   event->params.SetDouble("buffer_start", start);
   event->params.SetDouble("buffer_current", current);
   event->params.SetDouble("buffer_end", end);
   return event.Pass();
 }
 
 scoped_ptr<MediaLogEvent> MediaLog::CreateMediaSourceErrorEvent(
     const std::string& error) {
   scoped_ptr<MediaLogEvent> event(
       CreateEvent(MediaLogEvent::MEDIA_SOURCE_ERROR));
   event->params.SetString("error", error);
   return event.Pass();
 }
 
 }  //namespace media