Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(965)

Issue 2195293002: Revert of Adds a WebRTC browser_test with opus dtx enabled. (Closed)

Created:
4 years, 4 months ago by Guido Urdaneta
Modified:
4 years, 4 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, mcasas+watch+vc_chromium.org, miu+watch_chromium.org, phoglund+watch_chromium.org, tnakamura+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Adds a WebRTC browser_test with opus dtx enabled. (patchset #5 id:100001 of https://codereview.chromium.org/2190533002/ ) Reason for revert: Speculative revert due to this CL being suspect of breaking webrtc bots. See https://build.chromium.org/p/chromium.webrtc/builders/Linux%20Tester/builds/19829 Sample error message: [32431:32431:0801/012147:INFO:CONSOLE(13)] "Returning Test failed: Error: getSdpDefaultCodec() failed: "'m=video' line missing from |sdp|." at failTest (http://127.0.0.1:47758/webrtc/test_functions.js:46:15) at failure (http://127.0.0.1:47758/webrtc/test_functions.js:56:9) at getSdpDefaultCodec (http://127.0.0.1:47758/webrtc/munge_sdp.js:108:5) at getSdpDefaultVideoCodec (http://127.0.0.1:47758/webrtc/munge_sdp.js:93:10) at verifyDefaultVideoCodec (http://127.0.0.1:47758/webrtc/peerconnection.js:174:27) at <anonymous>:1:51 to test.", source: http://127.0.0.1:47758/webrtc/test_functions.js (13) ../../chrome/browser/media/webrtc_browsertest_base.cc:361: Failure Original issue's description: > Adds a WebRTC browser_test with opus dtx enabled. > > Additionally, starts tracking the 'packetsSentPerSecond' metric for WebRTC browser_tests. > > BUG=631927 > > Committed: https://crrev.com/e9df939bf67e2dea8e3ca1d9a0857272324611b8 > Cr-Commit-Position: refs/heads/master@{#408825} TBR=jochen@chromium.org,minyue@chromium.org,phoglund@chromium.org,ivoc@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=631927 Committed: https://crrev.com/0dc179b22f88b81c6a083670bb09f22108420a4e Cr-Commit-Position: refs/heads/master@{#408937}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -197 lines) Patch
M chrome/browser/extensions/api/webrtc_logging_private/webrtc_event_log_apitest.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/media/webrtc_browsertest.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/media/webrtc_browsertest_base.h View 2 chunks +11 lines, -12 lines 0 comments Download
M chrome/browser/media/webrtc_browsertest_base.cc View 5 chunks +28 lines, -23 lines 0 comments Download
M chrome/browser/media/webrtc_browsertest_perf.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/media/webrtc_perf_browsertest.cc View 6 chunks +9 lines, -39 lines 0 comments Download
M chrome/browser/media/webrtc_video_quality_browsertest.cc View 1 chunk +1 line, -5 lines 0 comments Download
M chrome/test/data/webrtc/munge_sdp.js View 2 chunks +0 lines, -44 lines 0 comments Download
M chrome/test/data/webrtc/peerconnection.js View 5 chunks +18 lines, -58 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Guido Urdaneta
Created Revert of Adds a WebRTC browser_test with opus dtx enabled.
4 years, 4 months ago (2016-08-01 09:38:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2195293002/1
4 years, 4 months ago (2016-08-01 09:39:03 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-01 10:32:43 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 10:34:15 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0dc179b22f88b81c6a083670bb09f22108420a4e
Cr-Commit-Position: refs/heads/master@{#408937}

Powered by Google App Engine
This is Rietveld 408576698