Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issue 2195273003: Deprecate SPDY/3.1 and draft HTTP/2 enum values. (Closed)

Created:
4 years, 4 months ago by Bence
Modified:
4 years, 4 months ago
CC:
chromium-reviews, Dirk Pranke, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Deprecate SPDY/3.1 and draft HTTP/2 enum values. * Remove NextProto::kProtoSPDY31 enum value. * Remove unused enum NextProto values: kProtoSPDY31, kProtoMinimumVersion, kProtoMaximumVersion, kProtoSPDYMinimumVersion, kProtoSPDYMaximumVersion. * Remove (and inline) now trivial NextProtoIsSPDY(); remove next_proto.cc. * Deprecate enum HttpResponseInfo values: CONNECTION_INFO_SPDY3, CONNECTION_INFO_HTTP2_14, CONNECTION_INFO_HTTP2_15. SPDY/3.1, HTTP/2 draft-14, and HTTP/2 draft-15 protocols are not supported any more. This CL cleans up deprecated enum values: removes them where it is possible, marks them DEPRECATED where it is not. BUG=624095 Committed: https://crrev.com/7ba7da8cd9714c01a5ef0ef8ad3320d5574c1cab Cr-Commit-Position: refs/heads/master@{#409506}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -48 lines) Patch
M components/domain_reliability/util.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M net/http/http_proxy_client_socket_wrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_response_info.h View 1 chunk +3 lines, -3 lines 0 comments Download
M net/http/http_response_info.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M net/http/http_server_properties.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M net/http/http_stream_factory_impl_job.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/net.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M net/socket/next_proto.h View 1 chunk +1 line, -13 lines 0 comments Download
D net/socket/next_proto.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M net/socket/ssl_client_socket.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M net/socket/ssl_client_socket_pool.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
Bence
Julia: PTAL at components/domain_reliability/. Ryan: PTAL at net/. Thank you both.
4 years, 4 months ago (2016-08-01 17:14:23 UTC) #6
Ryan Hamilton
lgtm
4 years, 4 months ago (2016-08-01 20:53:15 UTC) #7
Julia Tuttle
components/domain_reliability lgtm
4 years, 4 months ago (2016-08-03 12:21:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2195273003/1
4 years, 4 months ago (2016-08-03 12:52:57 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-03 14:08:53 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 14:10:52 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7ba7da8cd9714c01a5ef0ef8ad3320d5574c1cab
Cr-Commit-Position: refs/heads/master@{#409506}

Powered by Google App Engine
This is Rietveld 408576698