Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2195263002: MD History: UI polish pass (Closed)

Created:
4 years, 4 months ago by tsergeant
Modified:
4 years, 4 months ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: UI polish pass * Remove 'Psst' notice from delete confirmation dialog * Increase line-height of 'other forms of history' notice to 20px BUG=425625 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/44556d9c26d51c21682043270c3e3d036d283836 Cr-Commit-Position: refs/heads/master@{#408911}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -20 lines) Patch
M chrome/browser/resources/md_history/side_bar.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/history_ui.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/history_ui.cc View 2 chunks +8 lines, -13 lines 0 comments Download
M chrome/browser/ui/webui/md_history_ui.cc View 3 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
tsergeant
4 years, 4 months ago (2016-08-01 03:16:41 UTC) #5
calamity
lgtm
4 years, 4 months ago (2016-08-01 03:40:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2195263002/1
4 years, 4 months ago (2016-08-01 05:08:17 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-01 05:11:26 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 05:13:00 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/44556d9c26d51c21682043270c3e3d036d283836
Cr-Commit-Position: refs/heads/master@{#408911}

Powered by Google App Engine
This is Rietveld 408576698