Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: src/messages.cc

Issue 2195243003: [api] Remove NeanderObject (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@2016-07-29_api_remove_NeanderArray_2196533003
Patch Set: fixing rebase issues Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/api.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/messages.cc
diff --git a/src/messages.cc b/src/messages.cc
index 176b28d40e2ec280553eb24dab17da9218fefd9b..87e0682f9723834af350ad613d5ce762576ec309 100644
--- a/src/messages.cc
+++ b/src/messages.cc
@@ -134,11 +134,11 @@ void MessageHandler::ReportMessage(Isolate* isolate, MessageLocation* loc,
for (int i = 0; i < global_length; i++) {
HandleScope scope(isolate);
if (global_listeners->get(i)->IsUndefined(isolate)) continue;
- v8::NeanderObject listener(JSObject::cast(global_listeners->get(i)));
- Handle<Foreign> callback_obj(Foreign::cast(listener.get(0)));
+ FixedArray* listener = FixedArray::cast(global_listeners->get(i));
+ Foreign* callback_obj = Foreign::cast(listener->get(0));
v8::MessageCallback callback =
FUNCTION_CAST<v8::MessageCallback>(callback_obj->foreign_address());
- Handle<Object> callback_data(listener.get(1), isolate);
+ Handle<Object> callback_data(listener->get(1), isolate);
{
// Do not allow exceptions to propagate.
v8::TryCatch try_catch(reinterpret_cast<v8::Isolate*>(isolate));
« no previous file with comments | « src/api.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698