Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Unified Diff: src/api.h

Issue 2195243003: [api] Remove NeanderObject (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@2016-07-29_api_remove_NeanderArray_2196533003
Patch Set: fixing rebase issues Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/api.h
diff --git a/src/api.h b/src/api.h
index 661ffe0f728954739ab487e8d656816ccf1aa6ab..26e47ccb52882455abba052c8c301a35ca5b7b6e 100644
--- a/src/api.h
+++ b/src/api.h
@@ -26,44 +26,6 @@ class Consts {
};
};
-
-// Utilities for working with neander-objects, primitive
-// env-independent JSObjects used by the api.
-class NeanderObject {
- public:
- explicit NeanderObject(v8::internal::Isolate* isolate, int size);
- explicit inline NeanderObject(v8::internal::Handle<v8::internal::Object> obj);
- explicit inline NeanderObject(v8::internal::Object* obj);
- inline v8::internal::Object* get(int index);
- inline void set(int index, v8::internal::Object* value);
- inline v8::internal::Handle<v8::internal::JSObject> value() { return value_; }
- int size();
- private:
- v8::internal::Handle<v8::internal::JSObject> value_;
-};
-
-
-NeanderObject::NeanderObject(v8::internal::Handle<v8::internal::Object> obj)
- : value_(v8::internal::Handle<v8::internal::JSObject>::cast(obj)) { }
-
-
-NeanderObject::NeanderObject(v8::internal::Object* obj)
- : value_(v8::internal::Handle<v8::internal::JSObject>(
- v8::internal::JSObject::cast(obj))) { }
-
-
-v8::internal::Object* NeanderObject::get(int offset) {
- DCHECK(value()->HasFastObjectElements());
- return v8::internal::FixedArray::cast(value()->elements())->get(offset);
-}
-
-
-void NeanderObject::set(int offset, v8::internal::Object* value) {
- DCHECK(value_->HasFastObjectElements());
- v8::internal::FixedArray::cast(value_->elements())->set(offset, value);
-}
-
-
template <typename T> inline T ToCData(v8::internal::Object* obj) {
STATIC_ASSERT(sizeof(T) == sizeof(v8::internal::Address));
if (obj == v8::internal::Smi::FromInt(0)) return nullptr;
@@ -158,9 +120,6 @@ class Utils {
}
static void ReportOOMFailure(const char* location, bool is_heap_oom);
- static Local<FunctionTemplate> ToFunctionTemplate(NeanderObject obj);
- static Local<ObjectTemplate> ToObjectTemplate(NeanderObject obj);
-
static inline Local<Context> ToLocal(
v8::internal::Handle<v8::internal::Context> obj);
static inline Local<Value> ToLocal(
« no previous file with comments | « no previous file | src/api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698