Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 219523004: Let MediaController.currentTime return the position previously set (Closed)

Created:
6 years, 8 months ago by philipj_slow
Modified:
6 years, 8 months ago
CC:
blink-reviews, feature-media-reviews_chromium.org, dglazkov+blink, philipj_slow, adamk+blink_chromium.org, eric.carlson_apple.com
Visibility:
Public.

Description

Let MediaController.currentTime return the position previously set BUG=358226 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170504

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M LayoutTests/media/media-controller-playback.html View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/media/media-controller-playback-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/MediaController.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
philipj_slow
PTAL. This is required for the test in https://codereview.chromium.org/219283004/ to pass.
6 years, 8 months ago (2014-03-31 17:29:42 UTC) #1
acolwell GONE FROM CHROMIUM
lgtm
6 years, 8 months ago (2014-03-31 22:21:38 UTC) #2
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 8 months ago (2014-04-01 01:33:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/219523004/1
6 years, 8 months ago (2014-04-01 01:33:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/219523004/1
6 years, 8 months ago (2014-04-01 01:34:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/219523004/1
6 years, 8 months ago (2014-04-01 01:34:36 UTC) #6
commit-bot: I haz the power
6 years, 8 months ago (2014-04-01 02:11:39 UTC) #7
Message was sent while issue was closed.
Change committed as 170504

Powered by Google App Engine
This is Rietveld 408576698