Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(734)

Issue 219523003: Provide Type::Contains methods. (Closed)

Created:
6 years, 8 months ago by rossberg
Modified:
6 years, 8 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Visibility:
Public.

Description

Provide Type::Contains methods. Also, rename all *Currently methods to Now*. R=bmeurer@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=20405

Patch Set 1 #

Patch Set 2 : Allow raw pointers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -9 lines) Patch
M src/ic.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/types.h View 1 1 chunk +10 lines, -3 lines 0 comments Download
M src/types.cc View 1 3 chunks +19 lines, -2 lines 0 comments Download
M src/typing.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
rossberg
6 years, 8 months ago (2014-03-31 15:41:02 UTC) #1
Benedikt Meurer
LGTM
6 years, 8 months ago (2014-04-01 11:17:15 UTC) #2
rossberg
6 years, 8 months ago (2014-04-01 13:11:22 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r20405 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698