Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 219523002: Move extension whitelist switch to //extensions (Closed)

Created:
6 years, 8 months ago by Ken Rockot(use gerrit already)
Modified:
6 years, 8 months ago
Reviewers:
scheib
CC:
chromium-reviews, extensions-reviews_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, Lei Zhang, Greg Billock, nona+watch_chromium.org, oshima+watch_chromium.org, tommycli, vandebo (ex-Chrome), chromium-apps-reviews_chromium.org, miu+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Move extension whitelist switch to //extensions BUG=358176 TBR=mfoltz@chromium.org for cast, dial, mdns TBR=hubbe@chromium.org for cast_streaming, tab_capture TBR=gbillock@chromium.org for media_galleries TBR=stevenjb@chromium.org for networking_private Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260669

Patch Set 1 #

Patch Set 2 : fix ugly whitespace #

Patch Set 3 : namespace conflict #

Patch Set 4 : fix cros #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -36 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/input_method_apitest_chromeos.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/cast_channel/cast_channel_apitest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/cast_streaming/cast_streaming_apitest.cc View 1 2 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/cast_streaming/performance_test.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/dial/dial_apitest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/mdns/mdns_apitest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/media_galleries_private/media_galleries_watch_apitest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/networking_private/networking_private_apitest.cc View 3 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/tab_capture/tab_capture_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/tab_capture/tab_capture_apitest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/tab_capture/tab_capture_performancetest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/terminal/terminal_private_apitest.cc View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/common/extensions/features/simple_feature.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M extensions/common/switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/common/switches.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Ken Rockot(use gerrit already)
Please take a look. Purely a mechanical change so some additional code can move to ...
6 years, 8 months ago (2014-03-31 15:31:12 UTC) #1
scheib
lgtm
6 years, 8 months ago (2014-03-31 16:23:00 UTC) #2
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 8 months ago (2014-03-31 16:25:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/219523002/20001
6 years, 8 months ago (2014-03-31 16:27:44 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-31 17:17:12 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_compile_dbg
6 years, 8 months ago (2014-03-31 17:17:13 UTC) #6
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 8 months ago (2014-03-31 17:22:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/219523002/40001
6 years, 8 months ago (2014-03-31 17:22:41 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-31 18:45:41 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_clang_dbg
6 years, 8 months ago (2014-03-31 18:45:42 UTC) #10
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 8 months ago (2014-03-31 19:40:03 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/219523002/60001
6 years, 8 months ago (2014-03-31 19:40:35 UTC) #12
commit-bot: I haz the power
6 years, 8 months ago (2014-03-31 22:09:22 UTC) #13
Message was sent while issue was closed. 
Change committed as 260669

Powered by Google App Engine
This is Rietveld 408576698