Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issue 2195223002: Add data dependency directories for blink_tests in BUILD.gn. (Closed)

Created:
4 years, 4 months ago by qyearsley
Modified:
4 years, 4 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add data dependency directories for blink_tests in BUILD.gn. Suggested in http://crrev.com/2190163003. This should make it so that the analyze step identifies blink_tests as a dependency for changes in layout tests and WebKit/Tools/Scripts. BUG=631014 Committed: https://crrev.com/165a17a8f5c39b2e0ab1df3bdaa381222605b0ce Cr-Commit-Position: refs/heads/master@{#408996}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M BUILD.gn View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
qyearsley
4 years, 4 months ago (2016-08-01 16:55:04 UTC) #3
Dirk Pranke
lgtm
4 years, 4 months ago (2016-08-01 16:57:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2195223002/1
4 years, 4 months ago (2016-08-01 16:58:55 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-01 17:59:11 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 18:02:57 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/165a17a8f5c39b2e0ab1df3bdaa381222605b0ce
Cr-Commit-Position: refs/heads/master@{#408996}

Powered by Google App Engine
This is Rietveld 408576698