Recognize new Operating System: NetBSD

Recognize new Operating System: NetBSD

NetBSD is BSD and POSIX-like OS.

BUG=

Committed: https://crrev.com/969759f9970274b3aa8eae234b3d23eba398887d
Cr-Commit-Position: refs/heads/master@{#408895}

[Dirk Pranke, 2016-07-31 21:50:16]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-07-31 21:50:16]

The CQ bit was checked by dpranke@chromium.org

[Dirk Pranke, 2016-07-31 21:50:17]

lgtm

[commit-bot: I haz the power, 2016-07-31 21:50:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-31 21:55:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-31 21:55:10]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Dirk Pranke, 2016-07-31 21:58:03]

Looks like you need to fix these things:

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

./gyp_chromium_test.py (0.11s)

** Presubmit Warnings **
krytarowski@gmail.com is not in AUTHORS file. If you are a new contributor,
please visit
http://www.chromium.org/developers/contributing-code and read the "Legal"
section
If you are a chromite, verify the contributor signed the CLA.

** Presubmit ERRORS **
Possibly invalid OS macro[s] found. Please fix your code
or add your macro to src/PRESUBMIT.py.
      build/build_config.h:72 OS_NETBSD (did you mean OS_NACL?)

step returned non-zero exit code: 1

[Dirk Pranke, 2016-07-31 21:58:50]

On 2016/07/31 21:58:03, Dirk Pranke wrote:
> ** Presubmit Warnings **
> mailto:krytarowski@gmail.com is not in AUTHORS file. If you are a new
contributor,
> please visit
> http://www.chromium.org/developers/contributing-code and read the "Legal"
> section
> If you are a chromite, verify the contributor signed the CLA.

I verified that you signed the CLA, so you just need to add yourself to the
AUTHORS file and fix the PRESUBMIT check.

[Kamil Rytarowski, 2016-07-31 22:04:26]

On 2016/07/31 21:58:50, Dirk Pranke wrote:
> On 2016/07/31 21:58:03, Dirk Pranke wrote:
> > ** Presubmit Warnings **
> > mailto:krytarowski@gmail.com is not in AUTHORS file. If you are a new
> contributor,
> > please visit
> > http://www.chromium.org/developers/contributing-code and read the "Legal"
> > section
> > If you are a chromite, verify the contributor signed the CLA.
> 
> I verified that you signed the CLA, so you just need to add yourself to the
> AUTHORS file and fix the PRESUBMIT check.

Thanks for quick reply!

I'm going to find that file, add there myself, squash with the submitted commit
and resubmit here.

[Kamil Rytarowski, 2016-07-31 22:15:14]

On 2016/07/31 22:04:26, krytarowski wrote:
> On 2016/07/31 21:58:50, Dirk Pranke wrote:
> > On 2016/07/31 21:58:03, Dirk Pranke wrote:
> > > ** Presubmit Warnings **
> > > mailto:krytarowski@gmail.com is not in AUTHORS file. If you are a new
> > contributor,
> > > please visit
> > > http://www.chromium.org/developers/contributing-code and read the "Legal"
> > > section
> > > If you are a chromite, verify the contributor signed the CLA.
> > 
> > I verified that you signed the CLA, so you just need to add yourself to the
> > AUTHORS file and fix the PRESUBMIT check.
> 
> Thanks for quick reply!
> 
> I'm going to find that file, add there myself, squash with the submitted
commit
> and resubmit here.

Should be fine now.

[Dirk Pranke, 2016-07-31 22:32:05]

You need to fix the PRESUBMIT.py check to recognize OS_NETBSD as well:

https://cs.chromium.org/chromium/src/PRESUBMIT.py?rcl=0&l=2045

[Kamil Rytarowski, 2016-07-31 22:49:52]

On 2016/07/31 22:32:05, Dirk Pranke wrote:
> You need to fix the PRESUBMIT.py check to recognize OS_NETBSD as well:
> 
> https://cs.chromium.org/chromium/src/PRESUBMIT.py?rcl=0&l=2045

It should be fine now.

I was unsure whether I need to add an entry in this code:

def _DidYouMeanOSMacro(bad_macro):
  try:
    return {'A': 'OS_ANDROID',
            'B': 'OS_BSD',
            'C': 'OS_CHROMEOS',
            'F': 'OS_FREEBSD',
            'L': 'OS_LINUX',
            'M': 'OS_MACOSX',
            'N': 'OS_NACL',
            'O': 'OS_OPENBSD',
            'P': 'OS_POSIX',
            'S': 'OS_SOLARIS',
            'W': 'OS_WIN'}[bad_macro[3].upper()]
  except KeyError:
    return ''

https://cs.chromium.org/chromium/src/PRESUBMIT.py?rcl=0&l=2043

If so, will it be fine to add it under 'NE'?

[Kamil Rytarowski, 2016-07-31 23:18:01]

On 2016/07/31 22:49:52, krytarowski wrote:
> On 2016/07/31 22:32:05, Dirk Pranke wrote:
> > You need to fix the PRESUBMIT.py check to recognize OS_NETBSD as well:
> > 
> > https://cs.chromium.org/chromium/src/PRESUBMIT.py?rcl=0&l=2045
> 
> It should be fine now.
> 
> I was unsure whether I need to add an entry in this code:
> 
> def _DidYouMeanOSMacro(bad_macro):
>   try:
>     return {'A': 'OS_ANDROID',
>             'B': 'OS_BSD',
>             'C': 'OS_CHROMEOS',
>             'F': 'OS_FREEBSD',
>             'L': 'OS_LINUX',
>             'M': 'OS_MACOSX',
>             'N': 'OS_NACL',
>             'O': 'OS_OPENBSD',
>             'P': 'OS_POSIX',
>             'S': 'OS_SOLARIS',
>             'W': 'OS_WIN'}[bad_macro[3].upper()]
>   except KeyError:
>     return ''
> 
> https://cs.chromium.org/chromium/src/PRESUBMIT.py?rcl=0&l=2043
> 
> If so, will it be fine to add it under 'NE'?

OK, it will unlikely work there. but it's not crucial to alter it.

[Dirk Pranke, 2016-07-31 23:18:08]

On 2016/07/31 22:49:52, krytarowski wrote:
> On 2016/07/31 22:32:05, Dirk Pranke wrote:
> > You need to fix the PRESUBMIT.py check to recognize OS_NETBSD as well:
> > 
> > https://cs.chromium.org/chromium/src/PRESUBMIT.py?rcl=0&l=2045
> 
> It should be fine now.
> 
> I was unsure whether I need to add an entry in this code:
> 
> def _DidYouMeanOSMacro(bad_macro):
>   try:
>     return {'A': 'OS_ANDROID',
>             'B': 'OS_BSD',
>             'C': 'OS_CHROMEOS',
>             'F': 'OS_FREEBSD',
>             'L': 'OS_LINUX',
>             'M': 'OS_MACOSX',
>             'N': 'OS_NACL',
>             'O': 'OS_OPENBSD',
>             'P': 'OS_POSIX',
>             'S': 'OS_SOLARIS',
>             'W': 'OS_WIN'}[bad_macro[3].upper()]
>   except KeyError:
>     return ''
> 
> https://cs.chromium.org/chromium/src/PRESUBMIT.py?rcl=0&l=2043
> 
> If so, will it be fine to add it under 'NE'?

Ah, I didn't stare at the code closely enough to see what it was doing. Adding
OS_NETBSD
to VALID_OS_MACROS was the right thing to do. 

Adding 'NE' to DidYouMeanOSMacro won't actually work, since the implementation
looks
like it is really stupid and is only looking at a single letter. So, let's just
leave that alone.

(We could change it to bad_macro[3:4] and change 'A' -> 'AN', 'B' -> 'BSD', etc.
but I'm not
sure it's worth it.

[Dirk Pranke, 2016-07-31 23:18:15]

The CQ bit was checked by dpranke@chromium.org

[Dirk Pranke, 2016-07-31 23:18:15]

lgtm

[commit-bot: I haz the power, 2016-07-31 23:18:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-31 23:55:27]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-01 00:00:06]

Description was changed from

==========
Recognize new Operating System: NetBSD

NetBSD is BSD and POSIX-like OS.

BUG=
==========

to

==========
Recognize new Operating System: NetBSD

NetBSD is BSD and POSIX-like OS.

BUG=

Committed: https://crrev.com/969759f9970274b3aa8eae234b3d23eba398887d
Cr-Commit-Position: refs/heads/master@{#408895}
==========

[commit-bot: I haz the power, 2016-08-01 00:00:07]

Patchset 3 (id:??) landed as
https://crrev.com/969759f9970274b3aa8eae234b3d23eba398887d
Cr-Commit-Position: refs/heads/master@{#408895}

[Kamil Rytarowski, 2016-08-01 00:03:29]

On 2016/08/01 00:00:07, commit-bot: I haz the power wrote:
> Patchset 3 (id:??) landed as
> https://crrev.com/969759f9970274b3aa8eae234b3d23eba398887d
> Cr-Commit-Position: refs/heads/master@{#408895}

I think it's done. Thank you!