content/public/android/junit/src/org/chromium/content/browser/input/ThreadedInputConnectionTest.java - Issue 2195143002: [Android] Update all Robolectric tests to Robolectric 3.0

Unified Diff: content/public/android/junit/src/org/chromium/content/browser/input/ThreadedInputConnectionTest.java

Issue 2195143002: [Android] Update all Robolectric tests to Robolectric 3.0 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add OfflinePageTestRunner.java to CL Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/invalidation/impl/android/junit/src/org/chromium/components/invalidation/PendingInvalidationTest.java ('K') | « content/public/android/junit/src/org/chromium/content/browser/BindingManagerImplTest.java ('k') | net/android/BUILD.gn » ('j') | testing/android/junit/java/src/org/chromium/testing/local/RobolectricClasspathDependencyResolver.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/junit/src/org/chromium/content/browser/input/ThreadedInputConnectionTest.java

diff --git a/content/public/android/junit/src/org/chromium/content/browser/input/ThreadedInputConnectionTest.java b/content/public/android/junit/src/org/chromium/content/browser/input/ThreadedInputConnectionTest.java

index 22d3a47eae9f44843cf85a1e2233a92e75fe0fd4..719461394798026e040db87c621d7d36a05b76b2 100644

--- a/content/public/android/junit/src/org/chromium/content/browser/input/ThreadedInputConnectionTest.java

+++ b/content/public/android/junit/src/org/chromium/content/browser/input/ThreadedInputConnectionTest.java

@@ -23,6 +23,7 @@ import org.chromium.base.ThreadUtils;

import org.chromium.base.test.util.Feature;

import org.chromium.testing.local.LocalRobolectricTestRunner;

import org.junit.Before;

+import org.junit.Ignore;

import org.junit.Test;

import org.junit.runner.RunWith;

import org.mockito.InOrder;

@@ -35,7 +36,7 @@ import org.robolectric.annotation.Config;

* Unit tests for {@ThreadedInputConnection}.

@RunWith(LocalRobolectricTestRunner.class)

-@Config(manifest = Config.NONE)

+@Config(manifest = Config.NONE, sdk = 18)

public class ThreadedInputConnectionTest {

@Mock ImeAdapter mImeAdapter;

@@ -156,6 +157,7 @@ public class ThreadedInputConnectionTest {

@Test

@Feature({"TextInput"})

+ @Ignore("crbug/632792")

mikecase (-- gone --) 2016/07/31 04:21:10 These tests just hang. The tests say "should not h

jbudorick 2016/08/01 13:52:04 Sounds like something for the author/owner of this

public void testFailToRequestToRenderer() {

when(mImeAdapter.requestTextInputStateUpdate()).thenReturn(false);

// Should not hang here. Return null to indicate failure.

@@ -164,6 +166,7 @@ public class ThreadedInputConnectionTest {

@Test

@Feature({"TextInput"})

+ @Ignore("crbug/632792")

public void testRendererCannotUpdateState() {

when(mImeAdapter.requestTextInputStateUpdate()).thenReturn(true);

// We found that renderer cannot update state, e.g., due to a crash.