[Android] Update all Robolectric tests to Robolectric 3.0

third_party/robolectric/BUILD.gn

Index: third_party/robolectric/BUILD.gn
diff --git a/third_party/robolectric/BUILD.gn b/third_party/robolectric/BUILD.gn
index 4eba3000a5b93321723d83d0c69432aa233c3d88..2937e66730daa957a55c39761c1a62a8f12f0cdb 100644
--- a/third_party/robolectric/BUILD.gn
+++ b/third_party/robolectric/BUILD.gn
@@ -24,23 +24,7 @@ java_prebuilt("android-all-5.0.0_r2-robolectric-1") {
   jar_path = "lib/android-all-5.0.0_r2-robolectric-1.jar"
 }
 
-# TODO(mikecase): Remove this target once all tests have been converted to
-# Robolectric 3.0.
-# GYP: //third_party/robolectric/robolectric.gyp:robolectric_jar
-java_prebuilt("robolectric_java") {
-  testonly = true
-  jar_path = "lib/robolectric-2.4-jar-with-dependencies.jar"
-  deps = [
-    ":android-all-4.3_r2-robolectric-0",
-    ":json-20080701",
-    ":tagsoup-1.2",
-  ]
-}
-
-# TODO(mikecase): Rename target to robolectric_java once all tests have been
-# converted to Robolectric 3.0 and the old robolectric_java target has been
-# removed.
-java_library("robolectric_3_java") {
+java_library("robolectric_java") {
   testonly = true
   deps = [
     ":android-all-5.0.0_r2-robolectric-1",
@@ -594,27 +578,18 @@ template("shadows_core") {
       "robolectric/robolectric-shadows/resources/META-INF/services/org.robolectric.internal.ShadowProvider",
       "robolectric/robolectric-shadows/shadows-core/src/main/resources/META-INF/services/org.robolectric.ShadowsAdapter",
     ]
-    if (is_linux) {

[jbudorick, 2016/08/05 15:38:45]

I think what you wanted was
https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/referen...

[mikecase (-- gone --), 2016/08/05 16:15:43]

Woohoo! This works. Updated.

-      additional_jar_files = [
-        rebase_path("../sqlite4java/lib/linux-x86_64/libsqlite4java.so") +
-            ":linux-x86_64/libsqlite4java.so",
-        rebase_path("../sqlite4java/lib/linux-x86/libsqlite4java.so") +
-            ":linux-x86/libsqlite4java.so",
-      ]
-    }
-    if (is_mac) {
-      additional_jar_files =
-          [ rebase_path("../sqlite4java/lib/mac-x86_64/libsqlite4java.jnilib") +
-            ":mac-x86_64/libsqlite4java.jnilib" ]
-    }
-    if (is_win) {
-      additional_jar_files = [
-        rebase_path("../sqlite4java/lib/windows-x86/sqlite4java.dll") +
-            ":windows-x86/sqlite4java.dll",
-        rebase_path("../sqlite4java/lib/windows-x86_64/sqlite4java.dll") +
-            ":windows-x86_64/sqlite4java.dll",
-      ]
-    }
+    additional_jar_files = [
+      rebase_path("../sqlite4java/lib/linux-x86_64/libsqlite4java.so") +
+          ":linux-x86_64/libsqlite4java.so",
+      rebase_path("../sqlite4java/lib/linux-x86/libsqlite4java.so") +
+          ":linux-x86/libsqlite4java.so",
+      rebase_path("../sqlite4java/lib/mac-x86_64/libsqlite4java.jnilib") +
+          ":mac-x86_64/libsqlite4java.jnilib",
+      rebase_path("../sqlite4java/lib/windows-x86/sqlite4java.dll") +
+          ":windows-x86/sqlite4java.dll",
+      rebase_path("../sqlite4java/lib/windows-x86_64/sqlite4java.dll") +
+          ":windows-x86_64/sqlite4java.dll",
+    ]
     java_files = _shadows_core_java_files
     java_files += _processed_template_files