[Android] Update all Robolectric tests to Robolectric 3.0

third_party/robolectric/BUILD.gn

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/android/rules.gni")
 
 java_prebuilt("tagsoup-1.2") {
   testonly = true
   jar_path = "lib/tagsoup-1.2.jar"
 }
 
 java_prebuilt("json-20080701") {
   testonly = true
   jar_path = "lib/json-20080701.jar"
 }
 
 java_prebuilt("android-all-4.3_r2-robolectric-0") {
   testonly = true
   jar_path = "lib/android-all-4.3_r2-robolectric-0.jar"
 }
 
 java_prebuilt("android-all-5.0.0_r2-robolectric-1") {
   testonly = true
   jar_path = "lib/android-all-5.0.0_r2-robolectric-1.jar"
 }
 
-# TODO(mikecase): Remove this target once all tests have been converted to
-# Robolectric 3.0.
-# GYP: //third_party/robolectric/robolectric.gyp:robolectric_jar
-java_prebuilt("robolectric_java") {
-  testonly = true
-  jar_path = "lib/robolectric-2.4-jar-with-dependencies.jar"
-  deps = [
-    ":android-all-4.3_r2-robolectric-0",
-    ":json-20080701",
-    ":tagsoup-1.2",
-  ]
-}
-
-# TODO(mikecase): Rename target to robolectric_java once all tests have been
-# converted to Robolectric 3.0 and the old robolectric_java target has been
-# removed.
-java_library("robolectric_3_java") {
+java_library("robolectric_java") {
   testonly = true
   deps = [
     ":android-all-5.0.0_r2-robolectric-1",
     ":json-20080701",
     ":robolectric_annotations_java",
     ":robolectric_resources_java",
     ":robolectric_utils_java",
     ":shadows-core-3.0-18",
     ":shadows-core-3.0-21",
     ":shadows-multidex-3.0",
@@ skipping 526 matching lines @@
 
   java_library(target_name) {
     testonly = true
     processors_javac =
         [ "org.robolectric.annotation.processing.RobolectricProcessor" ]
     processor_args_javac = [ "org.robolectric.annotation.processing.shadowPackage=org.robolectric" ]
     provider_configurations = [
       "robolectric/robolectric-shadows/resources/META-INF/services/org.robolectric.internal.ShadowProvider",
       "robolectric/robolectric-shadows/shadows-core/src/main/resources/META-INF/services/org.robolectric.ShadowsAdapter",
     ]
-    if (is_linux) {
-      additional_jar_files = [
-        rebase_path("../sqlite4java/lib/linux-x86_64/libsqlite4java.so") +
-            ":linux-x86_64/libsqlite4java.so",
-        rebase_path("../sqlite4java/lib/linux-x86/libsqlite4java.so") +
-            ":linux-x86/libsqlite4java.so",
-      ]
-    }
-    if (is_mac) {
-      additional_jar_files =
-          [ rebase_path("../sqlite4java/lib/mac-x86_64/libsqlite4java.jnilib") +
-            ":mac-x86_64/libsqlite4java.jnilib" ]
-    }
-    if (is_win) {
-      additional_jar_files = [
-        rebase_path("../sqlite4java/lib/windows-x86/sqlite4java.dll") +
-            ":windows-x86/sqlite4java.dll",
-        rebase_path("../sqlite4java/lib/windows-x86_64/sqlite4java.dll") +
-            ":windows-x86_64/sqlite4java.dll",
-      ]
-    }
+    additional_jar_files = [

[jbudorick, 2016/08/03 15:32:29]

Why are we now adding all of these?

[mikecase (-- gone --), 2016/08/05 03:17:07]

I made a quick comment about this. When I changed this before, I assumed
is_linux would be true if you were on a linux workstation. Pretty sure is_linux
means you are building for linux. Really, you just need the library for w/e your
workstation is. But yeah, when I tried building and running tests with how it
was before, it was giving me an error that linux-x86_64/libsqlite4java.so
couldn't be found.

+      rebase_path("../sqlite4java/lib/linux-x86_64/libsqlite4java.so") +
+          ":linux-x86_64/libsqlite4java.so",
+      rebase_path("../sqlite4java/lib/linux-x86/libsqlite4java.so") +
+          ":linux-x86/libsqlite4java.so",
+      rebase_path("../sqlite4java/lib/mac-x86_64/libsqlite4java.jnilib") +
+          ":mac-x86_64/libsqlite4java.jnilib",
+      rebase_path("../sqlite4java/lib/windows-x86/sqlite4java.dll") +
+          ":windows-x86/sqlite4java.dll",
+      rebase_path("../sqlite4java/lib/windows-x86_64/sqlite4java.dll") +
+          ":windows-x86_64/sqlite4java.dll",
+    ]
     java_files = _shadows_core_java_files
     java_files += _processed_template_files
 
     deps = [
       ":$_process_templates_target_name",
       ":robolectric_annotations_java",
       ":robolectric_processor_java",
       ":robolectric_resources_java",
       ":robolectric_utils_java",
       "//build/android:sun_tools_java",
@@ skipping 30 matching lines @@
   deps = [
     ":android-all-5.0.0_r2-robolectric-1",
     ":robolectric_annotations_java",
     ":robolectric_processor_java",
     ":robolectric_utils_java",
     "//build/android:sun_tools_java",
     "//third_party/android_tools:android_support_multidex_java",
     "//third_party/guava:guava_java",
   ]
 }