Issue 219513005: Use apps::AppEventRouter to launch app_shell apps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 219513005: Use apps::AppEventRouter to launch app_shell apps (Closed)

Created:
6 years, 8 months ago by James Cook

Modified:
6 years, 8 months ago

Reviewers:
Ken Rockot(use gerrit already)

CC:
chromium-reviews, tfarina, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Use apps::AppEventRouter to launch app_shell apps Now that the app_runtime API has moved to //apps we can eliminate a small amount of code duplication in app_shell. BUG=357818 TEST=app_shell launches calculator Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260647

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -10 lines)			Patch
	M	apps/shell/browser/shell_extension_system.cc	View		2 chunks	+3 lines, -10 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Ken Rockot(use gerrit already)

On 2014/03/31 17:16:06, James Cook wrote: > rockot, PTAL woohoo, lgtm

6 years, 8 months ago (2014-03-31 17:17:04 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/219513005/1

6 years, 8 months ago (2014-03-31 17:21:03 UTC) #4

James Cook

6 years, 8 months ago (2014-04-03 17:00:35 UTC) #6

Message was sent while issue was closed.

A revert of this CL has been created in
https://codereview.chromium.org/224173002/ by jamescook@chromium.org.

The reason for reverting is: This creates an unwanted dependency from app_shell
back onto apps (we're moving it to depend only on extensions to keep the binary
small).
.

Expand Messages | Collapse Messages