Stop loading bundled Flash from chrome_content_client.cc

This change takes out the loading of the Flash bundle from chrome_content_client.cc on all platforms except Linux and ChromeOS, in preparation for removing Flash from the installation bundle on Windows and Mac. This should not result in any user-visible behavior changes, as the component updater will load the bundled component on Windows and Mac.

The change to the component installer is necessary to not remove command-line specified pepper plugins - see the bug for details.

BUG=628320
TEST=https://docs.google.com/document/d/1iTQiaqjuHsKV4cPqSOet-eJKWb2SsJLp2ieDj_Mul4s/edit?pref=2&pli=1

Committed: https://crrev.com/21d7beb1e2c02a8103d23126cf22838241fe794d
Cr-Commit-Position: refs/heads/master@{#413565}

[waffles, 2016-07-29 23:56:01]

The CQ bit was checked by waffles@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-29 23:56:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-30 00:38:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-30 00:38:49]

Dry run: This issue passed the CQ dry run.

[waffles, 2016-08-18 18:00:55]

The CQ bit was checked by waffles@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 18:01:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[waffles, 2016-08-18 18:23:06]

Description was changed from

==========
This is a demonstration CL only. I expect it to:
  * Pass CQ
  * But locally, have browser_tests fail when built with official build.

BUG=628320
==========

to

==========
This change takes out the loading of the Flash bundle from
chrome_content_client.cc on all platforms except Linux and ChromeOS, in
preparation for removing Flash from the installation bundle on Windows and Mac.
This should not result in any user-visible behavior changes, as the component
updater will load the bundled component on Windows and Mac.

The change to the component installer is necessary to not remove command-line
specified pepper plugins - see the bug for details.

BUG=628320
TEST=https://docs.google.com/document/d/1iTQiaqjuHsKV4cPqSOet-eJKWb2SsJLp2ieDj_Mul4s/edit?pref=2&pli=1
==========

[waffles, 2016-08-18 18:23:07]

waffles@chromium.org changed reviewers:
+ kerrnel@chromium.org, wfh@chromium.org

[waffles, 2016-08-18 18:41:07]

The CQ bit was checked by waffles@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 18:41:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 20:07:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 20:07:18]

Dry run: This issue passed the CQ dry run.

[waffles, 2016-08-18 20:38:58]

Greg, Will, PTAL.

I'm running through the testing plan now on Mac and Linux.

[Will Harris, 2016-08-18 20:42:05]

Hi, do you want me to run testing plan on Windows, with this CL patched in with
an official build? This is a one time offer! Expires 14.00PDT. No cash value.

[Greg K, 2016-08-18 20:45:26]

On 2016/08/18 20:38:58, waffles wrote:
> Greg, Will, PTAL.
> 
> I'm running through the testing plan now on Mac and Linux.

LGTM but please keep the description to 80 char width.

[waffles, 2016-08-18 21:05:09]

On 2016/08/18 20:42:05, Will Harris wrote:
> Hi, do you want me to run testing plan on Windows, with this CL patched in
with
> an official build? This is a one time offer! Expires 14.00PDT. No cash value.

Dang, late by 5 minutes! Yes, that would be helpful.

[waffles, 2016-08-19 17:00:33]

Completed testing on OSX and Linux without finding any problems. I skipped
network drive tests on both platforms, Flash debugger test on OSX (not
supported) and system-wide Flash on Linux (not supported).

[waffles, 2016-08-22 19:40:18]

On 2016/08/19 17:00:33, waffles wrote:
> Completed testing on OSX and Linux without finding any problems. I skipped
> network drive tests on both platforms, Flash debugger test on OSX (not
> supported) and system-wide Flash on Linux (not supported).

Completed testing on Win with Will's help.

[Will Harris, 2016-08-22 20:06:43]

lgtm but looks like you'll need a chrome/ owner

[waffles, 2016-08-22 20:11:16]

waffles@chromium.org changed reviewers:
+ thakis@chromium.org

[waffles, 2016-08-22 20:11:17]

thakis, PTAL.

[Nico, 2016-08-22 21:00:53]

lgtm

[waffles, 2016-08-22 21:05:26]

The CQ bit was checked by waffles@chromium.org

[commit-bot: I haz the power, 2016-08-22 21:07:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 22:50:35]

Description was changed from

==========
This change takes out the loading of the Flash bundle from
chrome_content_client.cc on all platforms except Linux and ChromeOS, in
preparation for removing Flash from the installation bundle on Windows and Mac.
This should not result in any user-visible behavior changes, as the component
updater will load the bundled component on Windows and Mac.

The change to the component installer is necessary to not remove command-line
specified pepper plugins - see the bug for details.

BUG=628320
TEST=https://docs.google.com/document/d/1iTQiaqjuHsKV4cPqSOet-eJKWb2SsJLp2ieDj_Mul4s/edit?pref=2&pli=1
==========

to

==========
This change takes out the loading of the Flash bundle from
chrome_content_client.cc on all platforms except Linux and ChromeOS, in
preparation for removing Flash from the installation bundle on Windows and Mac.
This should not result in any user-visible behavior changes, as the component
updater will load the bundled component on Windows and Mac.

The change to the component installer is necessary to not remove command-line
specified pepper plugins - see the bug for details.

BUG=628320
TEST=https://docs.google.com/document/d/1iTQiaqjuHsKV4cPqSOet-eJKWb2SsJLp2ieDj_Mul4s/edit?pref=2&pli=1
==========

[commit-bot: I haz the power, 2016-08-22 22:50:36]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-22 22:53:17]

Description was changed from

==========
This change takes out the loading of the Flash bundle from
chrome_content_client.cc on all platforms except Linux and ChromeOS, in
preparation for removing Flash from the installation bundle on Windows and Mac.
This should not result in any user-visible behavior changes, as the component
updater will load the bundled component on Windows and Mac.

The change to the component installer is necessary to not remove command-line
specified pepper plugins - see the bug for details.

BUG=628320
TEST=https://docs.google.com/document/d/1iTQiaqjuHsKV4cPqSOet-eJKWb2SsJLp2ieDj_Mul4s/edit?pref=2&pli=1
==========

to

==========
This change takes out the loading of the Flash bundle from
chrome_content_client.cc on all platforms except Linux and ChromeOS, in
preparation for removing Flash from the installation bundle on Windows and Mac.
This should not result in any user-visible behavior changes, as the component
updater will load the bundled component on Windows and Mac.

The change to the component installer is necessary to not remove command-line
specified pepper plugins - see the bug for details.

BUG=628320
TEST=https://docs.google.com/document/d/1iTQiaqjuHsKV4cPqSOet-eJKWb2SsJLp2ieDj_Mul4s/edit?pref=2&pli=1

Committed: https://crrev.com/21d7beb1e2c02a8103d23126cf22838241fe794d
Cr-Commit-Position: refs/heads/master@{#413565}
==========

[commit-bot: I haz the power, 2016-08-22 22:53:18]

Patchset 3 (id:??) landed as
https://crrev.com/21d7beb1e2c02a8103d23126cf22838241fe794d
Cr-Commit-Position: refs/heads/master@{#413565}