Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2195063003:
Linux: Sync GetDesktopName in gtk2_util.cc (Closed)
|
Created:
4 years, 4 months ago by Tom (Use chromium acct) Modified:
4 years, 4 months ago Reviewers:
Lei Zhang CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionLinux: Sync GetDesktopName in gtk2_util.cc
BUG=632841
Committed: https://crrev.com/12d7c7f1f6a38f067803c676e5cac9cccc11dab2
Cr-Commit-Position: refs/heads/master@{#408846}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Updated comment #
Messages
Total messages: 19 (11 generated)
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
thomasanderson@google.com changed reviewers: + thestig@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2195063003/diff/1/chrome/browser/ui/libgtk2ui... File chrome/browser/ui/libgtk2ui/gtk2_util.cc (right): https://codereview.chromium.org/2195063003/diff/1/chrome/browser/ui/libgtk2ui... chrome/browser/ui/libgtk2ui/gtk2_util.cc:61: // TODO(erg): This method was copied out of shell_integration_linux.cc. Because Can we update the comment? The two copies also need to have comments to remind folks to keep them in sync.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/07/30 00:40:33, Lei Zhang wrote: > https://codereview.chromium.org/2195063003/diff/1/chrome/browser/ui/libgtk2ui... > File chrome/browser/ui/libgtk2ui/gtk2_util.cc (right): > > https://codereview.chromium.org/2195063003/diff/1/chrome/browser/ui/libgtk2ui... > chrome/browser/ui/libgtk2ui/gtk2_util.cc:61: // TODO(erg): This method was > copied out of shell_integration_linux.cc. Because > Can we update the comment? The two copies also need to have comments to remind > folks to keep them in sync. Done. But I'm not 100% sure I understand what you mean about updating the comment. Still seems accurate to me
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/07/30 01:18:57, Tom Anderson wrote: > On 2016/07/30 00:40:33, Lei Zhang wrote: > > > https://codereview.chromium.org/2195063003/diff/1/chrome/browser/ui/libgtk2ui... > > File chrome/browser/ui/libgtk2ui/gtk2_util.cc (right): > > > > > https://codereview.chromium.org/2195063003/diff/1/chrome/browser/ui/libgtk2ui... > > chrome/browser/ui/libgtk2ui/gtk2_util.cc:61: // TODO(erg): This method was > > copied out of shell_integration_linux.cc. Because > > Can we update the comment? The two copies also need to have comments to remind > > folks to keep them in sync. > > Done. But I'm not 100% sure I understand what you mean about updating the > comment. Still seems accurate to me Oh it's fine. lgtm. I think I should have omitted "also".
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by thomasanderson@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Linux: Sync GetDesktopName in gtk2_util.cc BUG=632841 ========== to ========== Linux: Sync GetDesktopName in gtk2_util.cc BUG=632841 Committed: https://crrev.com/12d7c7f1f6a38f067803c676e5cac9cccc11dab2 Cr-Commit-Position: refs/heads/master@{#408846} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/12d7c7f1f6a38f067803c676e5cac9cccc11dab2 Cr-Commit-Position: refs/heads/master@{#408846}
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2196073002/ by miu@chromium.org. The reason for reverting is: Broke Linux GN build on my desktop (linker error): obj/chrome/browser/ui/libgtk2ui/libgtk2ui/gtk2_util.o:../../chrome/browser/ui/libgtk2ui/gtk2_util.cc:function libgtk2ui::GetDesktopName(base::Environment*): error: undefined reference to 'chrome::GetChannel()' clang: error: linker command failed with exit code 1 (use -v to see invocation) Contents of my out/Release/args.gn: is_component_build = true is_debug = false is_chrome_branded = true dcheck_always_on = true use_goma = true . |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
