Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2195043002: XXS: Update a comment in the safebrowsing.proto file (Closed)

Created:
4 years, 4 months ago by vakh (use Gerrit instead)
Modified:
4 years, 4 months ago
Reviewers:
woz, Jialiu Lin
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

XXS: Update a comment in the safebrowsing.proto file The comment states that although the field is marked as repeated, in practice it can only contain 0 or 1 values. BUG=543161 Committed: https://crrev.com/d0aec0f11810497a372d9187e65b7db4d81a15c7 Cr-Commit-Position: refs/heads/master@{#408767}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M components/safe_browsing_db/safebrowsing.proto View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
vakh (use Gerrit instead)
4 years, 4 months ago (2016-07-29 20:28:33 UTC) #3
vakh (use Gerrit instead)
4 years, 4 months ago (2016-07-29 20:29:57 UTC) #6
Jialiu Lin
lgtm
4 years, 4 months ago (2016-07-29 20:43:58 UTC) #7
Jialiu Lin
lgtm
4 years, 4 months ago (2016-07-29 20:44:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2195043002/1
4 years, 4 months ago (2016-07-29 21:05:42 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-29 21:26:57 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 21:29:16 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d0aec0f11810497a372d9187e65b7db4d81a15c7
Cr-Commit-Position: refs/heads/master@{#408767}

Powered by Google App Engine
This is Rietveld 408576698