chrome/browser/extensions/api/input/input.cc - Issue 219503003: Make keyboard controller a singleton.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/input/input.cc

Issue 219503003: Make keyboard controller a singleton. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix root window controller unittets. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/input/input.cc

diff --git a/chrome/browser/extensions/api/input/input.cc b/chrome/browser/extensions/api/input/input.cc

index 1a18af77519a518ad11056e7be7d6d5d7900efc0..f8db0cd8e2c998af864b31e2d62749736007058b 100644

--- a/chrome/browser/extensions/api/input/input.cc

+++ b/chrome/browser/extensions/api/input/input.cc

@@ -111,7 +111,7 @@ bool VirtualKeyboardPrivateHideKeyboardFunction::RunImpl() {

// Pass HIDE_REASON_MANUAL since calls to HideKeyboard as part of this API

// would be user generated.

- ash::Shell::GetInstance()->keyboard_controller()->HideKeyboard(

+ keyboard::KeyboardController::GetInstance()->HideKeyboard(

keyboard::KeyboardController::HIDE_REASON_MANUAL);

return true;

@@ -126,7 +126,7 @@ bool VirtualKeyboardPrivateLockKeyboardFunction::RunImpl() {

#if defined(USE_ASH)

bool lock;

EXTENSION_FUNCTION_VALIDATE(args_->GetBoolean(0, &lock));

- ash::Shell::GetInstance()->keyboard_controller()->set_lock_keyboard(lock);

+ keyboard::KeyboardController::GetInstance()->set_lock_keyboard(lock);

return true;

#else

error_ = kNotYetImplementedError;