Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Issue 2194953002: simplify neon shifts (Closed)

Created:
4 years, 4 months ago by mtklein_C
Modified:
4 years, 4 months ago
Reviewers:
msarett
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

simplify neon shifts These still generate vshr/vshl with immediates with both GCC and Clang. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2194953002 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Based on https://codereview.chromium.org/2196773002 Committed: https://skia.googlesource.com/skia/+/79b59e6a3877068067395ff8bd711c5332eb22a9

Patch Set 1 #

Patch Set 2 : merge right #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -34 lines) Patch
M src/opts/SkNx_neon.h View 1 6 chunks +8 lines, -34 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
mtklein_C
4 years, 4 months ago (2016-07-29 18:01:59 UTC) #4
msarett
lgtm
4 years, 4 months ago (2016-07-29 18:06:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2194953002/20001
4 years, 4 months ago (2016-07-29 19:00:43 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/79b59e6a3877068067395ff8bd711c5332eb22a9
4 years, 4 months ago (2016-07-29 19:28:50 UTC) #12
mtklein
4 years, 4 months ago (2016-07-30 20:35:10 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2193983003/ by mtklein@google.com.

The reason for reverting is: Reverting so I can revert
https://codereview.chromium.org/2196773002.

Powered by Google App Engine
This is Rietveld 408576698