Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 2194873002: Delete leftover comment in subresource filter rules definitions. (Closed)

Created:
4 years, 4 months ago by pkalinnikov
Modified:
4 years, 4 months ago
Reviewers:
engedy
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete leftover comment in subresource filter rules definitions. BUG=609747 Committed: https://crrev.com/536ea432350f23a084fcda1973619a0c6d661294 Cr-Commit-Position: refs/heads/master@{#408620}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M components/subresource_filter/core/common/proto/rules.proto View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
pkalinnikov
Balazs, here is a super-CL for you.
4 years, 4 months ago (2016-07-29 11:34:41 UTC) #2
engedy
LGTM. Can you please be a bit more specific in the CL description, such as ...
4 years, 4 months ago (2016-07-29 11:36:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2194873002/1
4 years, 4 months ago (2016-07-29 11:37:21 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-29 12:20:03 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 12:22:31 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/536ea432350f23a084fcda1973619a0c6d661294
Cr-Commit-Position: refs/heads/master@{#408620}

Powered by Google App Engine
This is Rietveld 408576698