src/IceCfg.cpp - Issue 2194853003: Subzero: Implemented codegen for poisoning and unpoisoning stack redzones

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceCfg.cpp

Issue 2194853003: Subzero: Implemented codegen for poisoning and unpoisoning stack redzones (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Added missing REQUIRES directive Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceCfg.cpp

diff --git a/src/IceCfg.cpp b/src/IceCfg.cpp

index d55f79bc75c01dc6304a72fc733ed28e29a7a33d..eace318238bdbc28c61e05fad28d411a84619f55 100644

--- a/src/IceCfg.cpp

+++ b/src/IceCfg.cpp

@@ -897,7 +897,7 @@ void Cfg::sortAndCombineAllocas(CfgVector<InstAlloca *> &Allocas,

uint32_t Align1 = A1->getAlignInBytes();

uint32_t Align2 = A2->getAlignInBytes();

if (Align1 == Align2)

- return A1->getNumber() > A2->getNumber();

+ return A1->getNumber() < A2->getNumber();

else

return Align1 > Align2;

});

« no previous file with comments | « src/IceASanInstrumentation.cpp ('k') | tests_lit/asan_tests/alignment.ll » ('j') | no next file with comments »