Cleanup CPDF_DocPageData release methods and callers.

core/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "core/fpdfapi/fpdf_page/pageint.h"
 
 #include <limits.h>
 
@@ skipping 142 matching lines @@
       pParam = pDict->GetDictBy("DecodeParms");
     }
   }
   uint32_t width = pDict->GetIntegerBy("Width");
   uint32_t height = pDict->GetIntegerBy("Height");
   uint32_t OrigSize = 0;
   if (pCSObj) {
     uint32_t bpc = pDict->GetIntegerBy("BitsPerComponent");
     uint32_t nComponents = 1;
     CPDF_ColorSpace* pCS = pDoc->LoadColorSpace(pCSObj);
-    if (!pCS) {
-      nComponents = 3;
-    } else {
+    if (pCS) {
       nComponents = pCS->CountComponents();
       pDoc->GetPageData()->ReleaseColorSpace(pCSObj);
+    } else {
+      nComponents = 3;
     }
     uint32_t pitch = width;
-    if (bpc && pitch > INT_MAX / bpc) {
+    if (bpc && pitch > INT_MAX / bpc)
       return nullptr;
-    }
+
     pitch *= bpc;
-    if (nComponents && pitch > INT_MAX / nComponents) {
+    if (nComponents && pitch > INT_MAX / nComponents)
       return nullptr;
-    }
+
     pitch *= nComponents;
-    if (pitch > INT_MAX - 7) {
+    if (pitch > INT_MAX - 7)
       return nullptr;
-    }
+
     pitch += 7;
     pitch /= 8;
     OrigSize = pitch;
   } else {
-    if (width > INT_MAX - 7) {
+    if (width > INT_MAX - 7)
       return nullptr;
-    }
+
     OrigSize = ((width + 7) / 8);
   }
-  if (height && OrigSize > INT_MAX / height) {
+  if (height && OrigSize > INT_MAX / height)
     return nullptr;
-  }
+
   OrigSize *= height;
   uint8_t* pData = nullptr;
   uint32_t dwStreamSize;
   if (Decoder.IsEmpty()) {
     if (OrigSize > m_Size - m_Pos) {
       OrigSize = m_Size - m_Pos;
     }
     pData = FX_Alloc(uint8_t, OrigSize);
     FXSYS_memcpy(pData, m_pBuf + m_Pos, OrigSize);
     dwStreamSize = OrigSize;
@@ skipping 617 matching lines @@
       }
       m_Status = Done;
       return;
     }
     steps++;
     if (pPause && pPause->NeedToPauseNow()) {
       break;
     }
   }
 }