object-stats.cc: Annotate PrintJSONArray with V8_NOINLINE

object-stats.cc: Annotate PrintJSONArray with V8_NOINLINE

Sometimes, the compiler will inline this function and unroll the loop.
Forcing this to never be inlined reduces the compiled size of the
function from a potential 170KB to around 39KB.

BUG=v8:5240
Committed: https://crrev.com/593ad0f7dfb87fce8e1033ad4a95519f90f5523d
Cr-Commit-Position: refs/heads/master@{#38172}

[dcheng, 2016-07-29 08:26:27]

dcheng@chromium.org changed reviewers:
+ cbruni@chromium.org

[dcheng, 2016-07-29 08:26:28]

This one is a bit non-deterministic: yesterday, it wasn't being inlined and
unrolled in official builds but it was in release builds.

Today, it's getting inlined and unrolled in official builds as well.

There's probably some more room for improvement here, but let's start with this.

[Camillo Bruni, 2016-07-29 08:47:36]

cbruni@chromium.org changed reviewers:
+ mlippautz@chromium.org

[Camillo Bruni, 2016-07-29 08:47:36]

I'm no heap owner, but would generally approve otherwise :)

[Michael Lippautz, 2016-07-29 09:02:35]

lgtm, thanks!

[dcheng, 2016-07-29 09:57:09]

I added a small comment so it's less mysterious why this one function is marked
noinline.

[dcheng, 2016-07-29 09:58:21]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2016-07-29 09:58:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlippautz@chromium.org
Link to the patchset: https://codereview.chromium.org/2194843002/#ps20001
(title: "Add comment")

[commit-bot: I haz the power, 2016-07-29 09:58:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 10:24:42]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-29 10:26:05]

Description was changed from

==========
object-stats.cc: Annotate PrintJSONArray with V8_NOINLINE

Sometimes, the compiler will inline this function and unroll the loop.
Forcing this to never be inlined reduces the compiled size of the
function from a potential 170KB to around 39KB.

BUG=v8:5240
==========

to

==========
object-stats.cc: Annotate PrintJSONArray with V8_NOINLINE

Sometimes, the compiler will inline this function and unroll the loop.
Forcing this to never be inlined reduces the compiled size of the
function from a potential 170KB to around 39KB.

BUG=v8:5240

Committed: https://crrev.com/593ad0f7dfb87fce8e1033ad4a95519f90f5523d
Cr-Commit-Position: refs/heads/master@{#38172}
==========

[commit-bot: I haz the power, 2016-07-29 10:26:06]

Patchset 2 (id:??) landed as
https://crrev.com/593ad0f7dfb87fce8e1033ad4a95519f90f5523d
Cr-Commit-Position: refs/heads/master@{#38172}